? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
10 Apr 2019

Pull Request for Issue # .

Summary of Changes

Changed td to th in table head of template default.php in com_contact.

Documentation Changes Required

No

avatar astridx astridx - open - 10 Apr 2019
avatar astridx astridx - change - 10 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Apr 2019
Category Administration com_contact
avatar alikon
alikon - comment - 10 Apr 2019

I have tested this item successfully on 4d2b2ff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24546.

avatar alikon alikon - test_item - 10 Apr 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Apr 2019

No. This was correct as TD.

avatar alikon
alikon - comment - 10 Apr 2019

not an expert but a td tag between th tag is correct ?
sorry for the dumb question

avatar brianteeman
brianteeman - comment - 10 Apr 2019

That cell is not a header. If you check the same field in other views you will see they are all td

avatar astridx
astridx - comment - 10 Apr 2019

That cell is not a header. If you check the same field in other views you will see they are all td

@brianteeman
Yes, I have seen that too. And also in the body of the table is a th element that I would change to a td.
But: I do not understand why that is. Could you explain that please?

avatar brianteeman
brianteeman - comment - 10 Apr 2019

The HTML < th > element defines a cell as header of a group of table cells

The HTML < td > element defines a cell of a table that contains data

avatar wilsonge
wilsonge - comment - 4 May 2019

Closing. Basically what Brian says is correct when you have a select all element it causes screenreader issues per https://stackoverflow.com/questions/39901980/select-all-checkbox-in-table-header-is-causing-issues and so the workaround for us has been to use a td element. in the head.

avatar wilsonge wilsonge - change - 4 May 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-05-04 14:49:35
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 4 May 2019
avatar astridx
astridx - comment - 4 May 2019

@wilsonge Many Thanks for the link. Now I think I have understood the problem.
If I see it correctly, the td element is a help. A better solution would be to move the "select-all" to the end of the table. But because the table can be spread over several pages, this is not trivial.

avatar wilsonge
wilsonge - comment - 4 May 2019

Yeah td is definitely a work around. We can probably create a tfooter to do the same thing. Unsure if it’s a better solution. But no it’s definitely not trivial.

Add a Comment

Login with GitHub to post a comment