User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Changed td
to th
in table head of template default.php in com_contact.
No
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_contact |
No. This was correct as TD.
not an expert but a td tag between th tag is correct ?
sorry for the dumb question
That cell is not a header. If you check the same field in other views you will see they are all td
That cell is not a header. If you check the same field in other views you will see they are all td
@brianteeman
Yes, I have seen that too. And also in the body of the table is a th
element that I would change to a td
.
But: I do not understand why that is. Could you explain that please?
The HTML < th > element defines a cell as header of a group of table cells
The HTML < td > element defines a cell of a table that contains data
Closing. Basically what Brian says is correct when you have a select all element it causes screenreader issues per https://stackoverflow.com/questions/39901980/select-all-checkbox-in-table-header-is-causing-issues and so the workaround for us has been to use a td element. in the head.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-04 14:49:35 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
@wilsonge Many Thanks for the link. Now I think I have understood the problem.
If I see it correctly, the td element is a help. A better solution would be to move the "select-all" to the end of the table. But because the table can be spread over several pages, this is not trivial.
Yeah td is definitely a work around. We can probably create a tfooter to do the same thing. Unsure if it’s a better solution. But no it’s definitely not trivial.
I have tested this item✅ successfully on 4d2b2ff
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24546.