Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24534] - [4.0] Adapting privacycheck quickicon to 4.0

? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
9 Apr 2019

Testing Instructions

Display Control panel.

Before patch

Screen Shot 2019-04-09 at 10 28 47

After patch

Screen Shot 2019-04-09 at 10 29 07

@wilsonge

avatar infograf768 infograf768 - open - 9 Apr 2019
avatar infograf768 infograf768 - change - 9 Apr 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Apr 2019
Category ⇒ Front End Plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Apr 2019

Test by Patchtester or npm?

avatar infograf768
infograf768 - comment - 9 Apr 2019

patchtester should work here as the js has been added a while ago.

avatar infograf768
infograf768 - comment - 9 Apr 2019

BUT some aspects have just been merged today:
#24531

Therfeore it may have to be tested with that patch in when clicking on the icon

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Apr 2019

I have tested this item ✅ successfully on 7200c0f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24534.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 9 Apr 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Apr 2019

I have not tested this item.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24534.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 9 Apr 2019 - Not tested
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Apr 2019

I have tested this item ✅ successfully on 7200c0f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24534.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 9 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Apr 2019
Easy No ⇒ Yes
avatar infograf768
infograf768 - comment - 9 Apr 2019

restarting drone but it may concern rips
@zero24

avatar infograf768
infograf768 - comment - 9 Apr 2019

@SharkyKZ
Just to remember that anyway we will have to modify this plugin as its js privacycheck.js uses JQuery and we have to modify this.
Therefore this is just a temporary fix until someone modifies both on the model of the other quickicons js and php

avatar infograf768 infograf768 - change - 9 Apr 2019
Labels Added: J4 Issue
avatar infograf768 infograf768 - change - 11 Apr 2019
Labels Added: ?
avatar infograf768 infograf768 - alter_testresult - 11 Apr 2019 - franz-wohlkoenig: Tested successfully
avatar richard67
richard67 - comment - 13 Apr 2019

I have tested this item ✅ successfully on 2f59918

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24534.

avatar richard67 richard67 - test_item - 13 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Apr 2019
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Apr 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - change - 14 Apr 2019
Labels Added: ?
Removed: J4 Issue
avatar wilsonge wilsonge - change - 14 Apr 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-04-14 19:38:19
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 14 Apr 2019
avatar wilsonge wilsonge - merge - 14 Apr 2019
avatar wilsonge
wilsonge - comment - 14 Apr 2019

Thanks!

Add a Comment

Login with GitHub to post a comment