[#24494] - [4.0] Fixed workflow conditions in search plugin
- Fixed in Code Base
- 18 Apr 2019
- Medium
- Build: 4.0-dev
- # 24494
- Diff
- bahl24:fix#24479-com_search-workflow-error
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24479 .
Summary of Changes
No results due to incorrect SQL query.
Expected result
Search page with results which are published
Actual result
Search always returns 0 results
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I tested and found that ws.condition=0 to be working.
That means there is a different problem to fix
| Labels |
Added:
?
|
||
I think I got the required solution.
Joining by ID always resulted in UNPUBLISHED state
| Title |
|
||||||
@bembelimen can you check this please
To get the correct state, you should always join over #__workflow_associations
Updated: wa.stage_id=2 is equivalent to ws.condition=2 as both refer to PUBLISHED state
Updated:
wa.stage_id=2is equivalent tows.condition=2as both refer to PUBLISHED state
That's only for the default workflow the case (and only by chance), see e.g. for the correct join: https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/Model/ArticlesModel.php#L231-L260
Updated: wa.stage_id=2 is equivalent to ws.condition=2 as both refer to PUBLISHED state
Only in the default workflow!!!
| Labels |
Added:
J4 Issue
|
||
You shouldn't use the magic number "1" but the extension class constant for conditions.
You shouldn't use the magic number "1" but the extension class constant for conditions.
Sorry, I didn't get you, ws.condition=1 points to published state. Is there an example regarding the extension class constant method?
The join on the #__workflow_associations table also needs to filter by extension = "com_content". Otherwise you also join on items from other extensions.
| Labels |
Removed:
J4 Issue
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-18 09:59:48 |
| Closed_By | ⇒ | wilsonge |
Thanks!
ws.condition=0 is the UNPUBLISHED state so that change cannot be correct can it?