Feeling Lucky
J3 Issue
?
[#24471] - AMP format please
- Closed
- 6 Apr 2019
- Medium
- Build: staging
- # 24471
Is your feature request related to a problem? Please describe.
I'am trying to remove scriptOptions from JDocument but it's protected property so I can't remove or disable it. I need to build joomla in amp format, so it's not allowed in amp format to add scripts except from amp source.
Describe the solution you'd like
I think Joomla should support html document type in AMP version
Additional context
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Status | New | ⇒ | Information Required |
| Category | ⇒ | Feature Request Templates (site) |
| Labels |
Added:
J3 Issue
|
||
franz-wohlkoenig
- comment
- 6 Apr 2019
Closed as stated above.
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-06 18:08:46 |
| Closed_By | ⇒ | franz-wohlkoenig |
Your template is in the scope of the Document class chain, so you can
$this->scriptOptions = [];all you want and take the risk of breaking something along the way. You're right there isn't a setter to just overwrite the property from outside, and making it public isn't the fix for that (it's wrong that there are so many public properties on the class in the first place but the time to fix that was in 2011, trying to fix it in 2019 is API suicide at this point).