Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24461] - [7.0] Separate activation from resetToken

Feature Ready to take over Conflicting Files Updates Requested Maintainers Checked PR-7.0-dev Success

User tests: Successful: Unsuccessful:

avatar Arpit-24
Arpit-24
2 Apr 2019

Pull Request for Issue #24269 .

Summary of Changes

Added new column of resetToken to users table.
Reset token expires after 3 days
The issue originally for 3.9 also existed in 4.0

Testing Instructions

Please refer to the original issue for details.

avatar Arpit-24 Arpit-24 - open - 2 Apr 2019
avatar Arpit-24 Arpit-24 - change - 2 Apr 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2019
Category ⇒ SQL Administration com_admin Postgresql Templates (admin) Front End com_users Language & Strings
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category SQL Administration com_admin Postgresql Templates (admin) Front End com_users Language & Strings ⇒ Administration com_admin com_users Front End Postgresql SQL Templates (admin)
avatar Kaustubharas Kaustubharas - test_item - 19 Oct 2019 - Tested successfully
avatar Kaustubharas
Kaustubharas - comment - 19 Oct 2019

I have tested this item ✅ successfully on 3f1645c

Tested this successfully.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

avatar ahghatol
ahghatol - comment - 19 Oct 2019

I have tested this item ✅ successfully on 3f1645c

avatar euismod2336
euismod2336 - comment - 19 Oct 2019

I doubt the change in the template is intentional ;) also, seems like a very convoluted way to determine if the resettoken is > 3 days? wouldn't now - date > (24 * 3600) * 3 be simpler to check? Do I also read it correct that now if you have an activationToken, you can never complete the reset process?

avatar anibalsanchez anibalsanchez - test_item - 15 Nov 2019 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 15 Nov 2019

I have tested this item ✅ successfully on 3f1645c

From #JMAD19 PBF

This PR already has two tests on the same commit ... but the system is counting only one....

I'm retesting it and making it count... it has 3 tests now.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.
avatar alikon
alikon - comment - 15 Nov 2019

@Arpit-24 can you solve conflict please

avatar Arpit-24 Arpit-24 - change - 16 Nov 2019
Labels Added: Conflicting Files ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2019
Category SQL Administration com_admin Postgresql Templates (admin) Front End com_users ⇒ SQL Administration com_admin Postgresql Front End com_users Language & Strings
avatar Arpit-24 Arpit-24 - change - 16 Nov 2019
Labels Added: ?
Removed: ?
avatar Arpit-24
Arpit-24 - comment - 16 Nov 2019

@Arpit-24 can you solve conflict please

Made the required changes

avatar Quy Quy - change - 16 Nov 2019
Labels Added: ?
Removed: Conflicting Files ?
avatar alikon
alikon - comment - 16 Nov 2019

you need to add that new field resetToken on installation too

avatar Arpit-24 Arpit-24 - change - 12 Jan 2020
Labels Added: ?
Removed: ?
avatar roland-d
roland-d - comment - 1 Aug 2020

@Arpit-24 Can you fix the conflicts once more please?

avatar Arpit-24 Arpit-24 - change - 2 Aug 2020
Labels Added: Conflicting Files ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2020
Category SQL Administration com_admin Postgresql Front End com_users Language & Strings ⇒ SQL Administration com_admin Postgresql Templates (admin) NPM Change Front End com_users Language & Strings
avatar Arpit-24 Arpit-24 - change - 2 Aug 2020
Labels Added: NPM Resource Changed
avatar Arpit-24 Arpit-24 - change - 2 Aug 2020
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2020
Category SQL Administration com_admin Postgresql Front End com_users Language & Strings Templates (admin) NPM Change ⇒ Unit Tests Repository Administration
avatar Arpit-24 Arpit-24 - change - 2 Aug 2020
Labels Added: ? ?
Removed: ? NPM Resource Changed ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2020
Category Administration Unit Tests Repository ⇒ SQL Administration com_admin Postgresql Front End com_users Language & Strings
avatar Arpit-24 Arpit-24 - change - 2 Aug 2020
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2020
Category Administration SQL com_admin Postgresql Front End com_users Language & Strings ⇒ SQL Administration com_admin Postgresql Front End com_users
avatar Arpit-24 Arpit-24 - change - 2 Aug 2020
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Aug 2020
Category Administration SQL com_admin Postgresql Front End com_users ⇒ SQL Administration com_admin Postgresql Front End com_users Language & Strings
avatar Quy
Quy - comment - 11 Aug 2020

@Arpit-24 Please add new field to \installation\sql\mysql\base.sql and \installation\sql\postgresql\base.sql. Thanks.

avatar tushar33 tushar33 - test_item - 17 Oct 2020 - Tested successfully
avatar tushar33
tushar33 - comment - 17 Oct 2020

I have tested this item ✅ successfully on 602056c

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

avatar degobbis degobbis - test_item - 17 Oct 2020 - Tested successfully
avatar degobbis
degobbis - comment - 17 Oct 2020

I have tested this item ✅ successfully on 602056c

Now the only thing missing is the possibility to set the expiration time for the token to the minute instead of having hardcoded 3 days.

I also think it would be a good practice to delete the reset token after confirmation and forwarding to the password change form, so that it can be used only once.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

avatar richard67
richard67 - comment - 17 Oct 2020

@Arpit-24 Please add new field to \installation\sql\mysql\base.sql and \installation\sql\postgresql\base.sql. Thanks.

This is still to be done, it seems.

avatar richard67 richard67 - change - 15 Mar 2021
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2021
Category Administration SQL com_admin Postgresql Front End com_users Language & Strings ⇒ SQL Administration com_admin Postgresql Front End com_users Installation Language & Strings
avatar drmenzelit
drmenzelit - comment - 2 Dec 2021

@Arpit-24 can you review the comments on this PR?

avatar bembelimen bembelimen - change - 22 Jan 2022
Labels Added: Language Change ? ? bug
Removed: ? ? ? ?
avatar bembelimen
bembelimen - comment - 22 Jan 2022

@Arpit-24 I've updated the branche to 4.1, because I think the idea behind this PR is not bad.

Probabla you could clean up the PR (like using DateTime classes for handling diffs etc) and we give it another go?

avatar richard67
richard67 - comment - 22 Jan 2022

The update SQL scripts would need a rename so they have the right version 4.1 and a newer date than the latest one which is already in the 4.1-dev branch, for example rename them from "4.0.0-2021-03-15.sql" to "4.1.0-2022-01-22.sql".

avatar Quy Quy - change - 27 Jan 2022
Labels Added: ?
Removed: ?
avatar Quy Quy - change - 28 Jan 2022
Labels Removed: bug
avatar laoneo
laoneo - comment - 6 Apr 2022

@Arpit-24 any intention to add the feedback?

avatar HLeithner
HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

avatar joomla-bot
joomla-bot - comment - 27 Jun 2022

This pull requests has been automatically converted to the PSR-12 coding standard.

avatar rdeutz rdeutz - change - 21 Oct 2022
Title
…
[4.0] Separate activation from resetToken
[5.0] Separate activation from resetToken
avatar rdeutz rdeutz - edited - 21 Oct 2022
avatar rdeutz rdeutz - change - 21 Oct 2022
Labels Added: Ready to take over ? ? PR-5.0-dev
Removed: ?
avatar bembelimen bembelimen - change - 22 Oct 2022
Labels Added: Maintainers Checked
Removed: ?
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar emedinainnotec emedinainnotec - test_item - 5 Oct 2023 - Tested successfully
avatar emedinainnotec
emedinainnotec - comment - 5 Oct 2023

I have tested this item ✅ successfully on f101243

Tested successfully

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

avatar bembelimen bembelimen - change - 2 Mar 2024
Labels Added: Feature Updates Requested PR-5.1-dev
Removed: ? ? PR-5.0-dev
avatar HLeithner HLeithner - change - 24 Apr 2024
Title
…
[5.0] Separate activation from resetToken
[5.2] Separate activation from resetToken
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar cybersalt cybersalt - test_item - 21 Aug 2024 - Tested unsuccessfully
avatar cybersalt
cybersalt - comment - 21 Aug 2024

I have tested this item ? unsuccessfully on f101243

Some of this worked. The user was not deactivated when the password reset was requested.

However, after logging in successfully the reset number did not return to zero - it remained at 1 - and even 2 when I reran the test.

I think there is a setting (?) that can be used to limit the number of resets, so in that case it matters. If reset has been requested and the user logs in, I guess reset count can be changed to whatever it is minus 1.

Also, the last reset time field still had the date - not "0000-00-00 00:00:00"

The

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24461.

avatar HLeithner
HLeithner - comment - 2 Sep 2024

This pull request has been automatically rebased to 5.3-dev.

avatar HLeithner HLeithner - change - 2 Sep 2024
Title
…
[5.2] Separate activation from resetToken
[5.3] Separate activation from resetToken
avatar HLeithner HLeithner - edited - 2 Sep 2024
avatar HLeithner
HLeithner - comment - 4 Mar 2025

This pull request has been automatically rebased to 6.0-dev.

avatar HLeithner HLeithner - change - 4 Mar 2025
Title
…
[5.3] Separate activation from resetToken
[6.0] Separate activation from resetToken
avatar HLeithner HLeithner - edited - 4 Mar 2025
avatar Bodge-IT Bodge-IT - change - 4 Jun 2025
Labels Added: PR-6.0-dev
Removed: PR-5.1-dev
avatar HLeithner
HLeithner - comment - 31 Aug 2025

This pull request has been automatically rebased to 6.1-dev.

avatar HLeithner HLeithner - change - 31 Aug 2025
Title
…
[6.0] Separate activation from resetToken
[6.1] Separate activation from resetToken
avatar HLeithner HLeithner - edited - 31 Aug 2025
avatar github-actions[bot]
github-actions[bot] - comment - 28 Feb 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar HLeithner
HLeithner - comment - 17 Mar 2026

This pull request has been automatically rebased to 6.2-dev.

avatar tecpromotion tecpromotion - change - 15 Apr 2026
Title
…
[6.1] Separate activation from resetToken
[6.2] Separate activation from resetToken
avatar tecpromotion tecpromotion - edited - 15 Apr 2026
avatar Hackwar Hackwar - change - 23 Aug 2026
Labels Added: Conflicting Files PR-6.2-dev
Removed: PR-6.0-dev
avatar HLeithner HLeithner - change - 26 Aug 2026
Title
…
[6.2] Separate activation from resetToken
[7.0] Separate activation from resetToken
avatar HLeithner HLeithner - edited - 26 Aug 2026
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2026
Category Administration SQL com_admin Postgresql Front End com_users Language & Strings Installation ⇒ Repository Administration com_admin SQL Postgresql com_banners com_categories com_checkin com_config com_contact com_content com_fields com_finder
avatar Hackwar Hackwar - change - 26 Aug 2026
Labels Added: PR-7.0-dev
Removed: Language Change Conflicting Files
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2026
Category Administration SQL com_admin Postgresql Repository com_banners com_categories com_checkin com_config com_contact com_content com_fields com_finder ⇒ Repository SQL Administration com_admin Postgresql com_banners com_categories com_checkin com_config com_contact com_content com_fields com_finder com_installer
avatar github-actions[bot]
github-actions[bot] - comment - 27 Aug 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

avatar Hackwar Hackwar - change - 27 Aug 2026
Labels Added: Conflicting Files
Removed: PR-6.2-dev
avatar joomla-cms-bot joomla-cms-bot - change - 27 Aug 2026
Category Administration SQL com_admin Postgresql Repository com_banners com_categories com_checkin com_config com_contact com_content com_fields com_finder com_installer ⇒ SQL Administration com_admin Postgresql Front End com_users Installation Language & Strings Templates (site)

Add a Comment

Login with GitHub to post a comment