J4 Issue ?
avatar N6REJ
N6REJ
2 Apr 2019

Steps to reproduce the issue

install clean dev_4.0
after installation run blog sample data installer

Expected result

sample data is installed and informs me its completed.
install button changes to "installed" or "completed"
progress bar goes away or CLEARLY indicates completed ( change color? )

Actual result

image

System information (as much as possible)

systeminfo-2019-04-02T20_55_44+00_00.txt

Additional comments

avatar N6REJ N6REJ - open - 2 Apr 2019
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 2 Apr 2019
avatar N6REJ N6REJ - change - 2 Apr 2019
The description was changed
avatar N6REJ N6REJ - edited - 2 Apr 2019
avatar N6REJ N6REJ - change - 2 Apr 2019
The description was changed
avatar N6REJ N6REJ - edited - 2 Apr 2019
avatar Bakual
Bakual - comment - 2 Apr 2019

The last message states it has been installed and the progress bar is at 100%. Imho it's quite clear.

Of course the bar could be changing colors (should be simple with CSS) - but I wouldn't make that specific for the sample data. Progress bars ideally look the same in the whole CMS.
I also wouldn't hide it. That would be strange and unexpected.

I wouldn't touch the "install" buttons. After a page refresh they would be back at initial state anyway.

Maybe the last message could be a different color or another text to indicate better it's the last one.

avatar N6REJ N6REJ - change - 2 Apr 2019
Title
Blog Sample Data doesn't show completed.
J4 Blog Sample Data doesn't show completed.
avatar N6REJ N6REJ - edited - 2 Apr 2019
avatar N6REJ N6REJ - change - 2 Apr 2019
Title
Blog Sample Data doesn't show completed.
J4 Blog Sample Data doesn't show completed.
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Apr 2019

Maybe the last message could be a different color (...) to indicate better it's the last one.

+1 for this.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2019
Title
J4 Blog Sample Data doesn't show completed.
[4.0] Blog Sample Data doesn't show completed.
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2019
Title
J4 Blog Sample Data doesn't show completed.
[4.0] Blog Sample Data doesn't show completed.
Status New Discussion
avatar joomla-cms-bot joomla-cms-bot - edited - 3 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2019
Category UI/UX
avatar hardik-codes
hardik-codes - comment - 3 Apr 2019

Maybe the last message could be a different color or another text to indicate better it's the last one.

@Bakual should I do these changes

avatar Bakual
Bakual - comment - 3 Apr 2019

@hardik-codes You don't have to ask for permission. Just do if you're interested ?

avatar hardik-codes
hardik-codes - comment - 3 Apr 2019

@Bakual What should be the exact change so that it is consistent with the joomla design?

avatar Bakual
Bakual - comment - 3 Apr 2019

I have no clue - I'm not a designer ?
Maybe @coolcat-creations has an idea.

avatar coolcat-creations
coolcat-creations - comment - 3 Apr 2019

If all the steps are bound to each other its enough to have 1 Progressbar, telling the current progress and in the end the result (installation of sample data completed) no need so much messages IMHO.

avatar infograf768
infograf768 - comment - 3 Apr 2019

it is not really. Some steps can succeed while others will not.

avatar brianteeman
brianteeman - comment - 3 Apr 2019

Is it ever possible for a scenario like this?
Step 1 - pass
Step 2 - fail
Step 3 - pass
Step 4 - pass

avatar infograf768
infograf768 - comment - 3 Apr 2019

Yes, I remarked that when the plugin was modified in 3.9 for security reasons.
It will be merged in 4.0 with this new code.

bbdf775#diff-8ca6ae5a8651d5eb87f3bad712894457

capture

In my test I had there refused core.create for menus to an admin.

For that case we could also add the the authorisation (core.create) for all components used in the first public function onSampledataGetOverview() therefore refusing to run the plugin when the user has no create rights for ALL the components involved.

Note : a failure for one iteration may also happen if the component concerned is NOT enabled.
Note 2 : It will be necessary anyway to make a patch for the multilingual sample data after the 3.9 commit is merged into 4.0

avatar Bakual
Bakual - comment - 3 Apr 2019

It can skip a step if some requirements are not met (eg if an extensions isn't installed), but that's still technically a success. If one step actually fails, the whole thing will stop and it will never go further.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar pe7er
pe7er - comment - 24 Apr 2019

I was also a bit confused about installing sample content:
the progress bar is animated, and keeps "moving" even after the installation has been completed.

<div class="progress">
	<div class="progress-bar progress-bar-striped progress-bar-animated bg-success" role="progressbar" aria-valuemin="0" aria-valuemax="100" aria-valuenow="100" style="width: 100%;">4/4</div>
</div>

Can't we remove the "progress-bar-animated" part with JavaScript after the installation has been finished?

avatar brianteeman
brianteeman - comment - 24 Apr 2019

better yet - remove the animated part completely as it fails a11y reduced-motion tests

avatar N6REJ N6REJ - change - 9 Sep 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-09-09 20:37:37
Closed_By N6REJ
avatar N6REJ N6REJ - close - 9 Sep 2019

Add a Comment

Login with GitHub to post a comment