[#24457] - [4.0] Dropped btn-xs in atum
- Closed
- 8 May 2019
- Medium
- Build: 4.0-dev
- # 24457
- Diff
- Harshil99:btn-xs
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure continuous-integration/drone/pr the build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #21244.
Testing Instructions
Compile by npm ci.
Expected result
xs buttons not working as removed in Bootstrap 4.
Actual result
xs buttons are displayed
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
@brianteeman Is it already stopped using or needed to change these classes ? I will try doing that.
Sorry I know you are trying to help but it doesnt take a second to do a search
Please add to the correct scss file. The one you've used is for imports
Would'nt it be OK in
/administrator/templates/atum/scss/vendor/bootstrap/_buttons.scss ?
lol
| Labels |
Added:
?
|
||
@infograf768 Moved changes to _buttons.scss.
franz-wohlkoenig
- | Category | Administration Templates (admin) | ⇒ | Administration NPM Change Templates (admin) |
Remove the class usage
| Category | Administration Templates (admin) NPM Change | ⇒ | Administration Templates (admin) |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-08 22:16:07 |
| Closed_By | ⇒ | Quy |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24457
Closing for now until a fix as suggested per wilsonge
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24457.
Much better to stop using the classes in the markup than to add them