? ? Success

User tests: Successful: Unsuccessful:

avatar 810
810
2 Apr 2019

Pull Request for Issue #24442.

Summary of Changes

composer updates

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar 810 810 - open - 2 Apr 2019
avatar 810 810 - change - 2 Apr 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2019
Category External Library Composer Change Libraries
avatar 810 810 - change - 2 Apr 2019
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Apr 2019
Category External Library Composer Change Libraries Repository External Library Composer Change Libraries
avatar HLeithner
HLeithner - comment - 3 Apr 2019

Is it normal that we have the test classes in the autoloader?

e.x. Joomla\Session\Tests\StorageCase

avatar mbabker
mbabker - comment - 3 Apr 2019

It won't hurt anything. The problem is after you do a composer update more often than not the gitignored files are going to be in your local filesystem, so when Composer generates the autoloaders because the files exist they'll be included in the maps. Short of writing a script to execute at the pre-autoload-dump event to clean this up, you're not going to consistently fix this.

avatar mbabker
mbabker - comment - 3 Apr 2019

Just for reference, it's a little better with the 4.0 build script because that explicitly runs composer install --no-dev --no-autoloader then cleans out non-shipped files before running composer dump-autoload --no-dev --optimize, but it still relies on regular review of the Composer installation and updating the script's clean_checkout() function.

avatar HLeithner
HLeithner - comment - 3 Apr 2019

thx for the info

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Apr 2019
Category External Library Composer Change Libraries Repository External Library Libraries Repository
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2019
Category External Library Libraries Repository Repository External Library Composer Change Libraries
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[3.9] Update Composer dependencies
Update Composer dependencies
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar HLeithner HLeithner - change - 23 Apr 2019
Labels Removed: J3 Issue
avatar HLeithner
HLeithner - comment - 23 Apr 2019

@mbabker the phpmailer update prevent the use of urls in addAttachement, even this maybe would be a b/c break for us. I'm not sure show this function is exposed in joomla.

avatar HLeithner HLeithner - change - 23 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-23 16:56:55
Closed_By HLeithner
avatar HLeithner HLeithner - close - 23 Apr 2019
avatar HLeithner HLeithner - merge - 23 Apr 2019
avatar HLeithner
HLeithner - comment - 23 Apr 2019

thx

avatar mbabker
mbabker - comment - 23 Apr 2019

You're going to have to review CVE-2018-19296 then as that's the reason URLs aren't allowed in that method.

avatar HLeithner
HLeithner - comment - 23 Apr 2019

I already thought that this change is a security fix, thats the reason I merged it. Thx for the info.

Add a Comment

Login with GitHub to post a comment