[#24440] - [4.0] Template styles column preview
- Fixed in Code Base
- 12 Apr 2019
- Medium
- Build: 4.0-dev
- # 24440
- Diff
- chmst:template-styles-column-preview
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure continuous-integration/drone/pr the build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Separate columns for module-position-preview and title in templates styles,
Hide the column "preview" in admin mode, as the feature is made only for frontend templates.
Testing Instructions
Before patch:
After patch:
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Title |
|
||||||
| Labels |
Added:
?
|
||
We also could hide the column "preview" for admin templates, as the feature is only used for frontend templates.
yes we could. I also thought about disabling the column if the preview is not enabled - but then I will get shouted at for making a hidden feature
We could hide it in the admin mode and show it always in the frontend mode. Then it is the same as for column "pages".
| Category | Administration com_templates | ⇒ | Administration com_templates Language & Strings |
@ChristineWk, @brianteeman could you re-test please?
| Labels |
Added:
?
|
||
One small CS issue otherwise its great and I will mark successful when that is fixed
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24440.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24440.
thank you - you fixed it ;)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24440.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24440.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24440.
| Labels |
Added:
?
|
||
@zero-24 @SniperSister RIPS please
franz-wohlkoenig
- | Category | Administration com_templates Language & Strings | ⇒ | Administration com_templates |
| Category | Administration com_templates | ⇒ | Administration com_templates Language & Strings |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-12 12:52:46 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on baf12a5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24440.