Joomla! Issue Tracker | Joomla! CMS #2443 - Moved $query object definition outside of conditional block.

Error

Error This pull request is targeted at the master branch. Pull requests should no longer be merged to master.

User tests: Successful: Unsuccessful:

davidangel
7 Nov 2013

Since there are multiple conditional blocks that may be using this
object, it needs to be defined outside of the first conditional blocks.

542c3c7 7 Nov 2013

davidangel - open - 7 Nov 2013

davidangel - close - 7 Nov 2013

davidangel - reopen - 7 Nov 2013

mbabker - comment - 7 Nov 2013

You should only need to define $query outside the block. Please change it so that you have this:

$query = $this->_db->getQuery(true); at line 317 in your updated file

$query->delete($this->_db->quoteName('#__user_usergroup_map'))
    ->where($this->_db->quoteName('user_id') . ' = ' . (int) $this->id);

That will be at line 325 before the $this->_db->setQuery($query); call.

0f91c9e 7 Nov 2013

davidangel - comment - 7 Nov 2013

How's that?

davidangel - comment - 7 Nov 2013

Strange, I then get this notification:

Password too long. Please select a password with 55 or fewer characters

but the registration seems to continue as normal...

mbabker - comment - 7 Nov 2013

Perfect Now we just need a report on Joomlacode (as that's still our primary issue tracker for the moment) at http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103 and we can get folks to test this patch and get it merged. Thanks for this!

As for the password issue, I saw some comments on the forum concerning it, this is something that needs investigated too.

brianteeman - change - 21 Aug 2014

Status	New	⇒	Pending
Build		⇒	.

wilsonge - comment - 23 Dec 2014

This was implemented with #2602 so closing this. Thanks so much for your contribution though!

wilsonge - change - 23 Dec 2014

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2014-12-23 00:34:57

wilsonge - close - 23 Dec 2014

Joomla! Issue Tracker - CMS