? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
31 Mar 2019

Pull Request for Issue zero-24/plg_system_httpheader#9

Summary of Changes

Add more single value headers to the singleValueResponseHeaders array in WebApplication

New headers added to the singleValueResponseHeaders array:

  • pragma
  • strict-transport-security
  • content-security-policy
  • content-security-policy-report-only
  • x-frame-options
  • x-xss-protection
  • x-content-type-options
  • referrer-policy
  • expect-ct
  • feature-policy

Testing Instructions

Expected result

image

Actual result

image

Documentation Changes Required

none

Side note

This is not limited to my plugin. Any other plugins setting that headers and even the core is affected by that bug (Pragma) in that specific caching case.

Mention

thanks @f-hamel for finding and reporting this issue. ?

avatar zero-24 zero-24 - open - 31 Mar 2019
avatar zero-24 zero-24 - change - 31 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Mar 2019
Category Libraries
avatar f-hamel
f-hamel - comment - 31 Mar 2019

I have tested this item successfully on 88cfd5c

Works fine.
No double headers anymore


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24429.

avatar f-hamel f-hamel - test_item - 31 Mar 2019 - Tested successfully
avatar zero-24 zero-24 - change - 1 Apr 2019
Labels Added: ?
avatar Quy
Quy - comment - 1 Apr 2019

I have tested this item successfully on cbf4bf9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24429.

avatar Quy Quy - test_item - 1 Apr 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Apr 2019

@f-hamel can you please retest?

avatar HLeithner
HLeithner - comment - 2 Apr 2019

I tested it successful, thx

avatar HLeithner HLeithner - change - 2 Apr 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-02 15:22:16
Closed_By HLeithner
avatar HLeithner HLeithner - close - 2 Apr 2019
avatar HLeithner HLeithner - merge - 2 Apr 2019
avatar zero-24
zero-24 - comment - 2 Apr 2019

Thanks

Add a Comment

Login with GitHub to post a comment