[#24427] - [4.0] fix template menu editor overlap
- Closed
- 3 May 2019
- Medium
- Build: 4.0-dev
- # 24427
- Diff
- hardik-codes:Fix#23512
- Success Hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23512
Summary of Changes
Changes in z-index as suggested in the issue
Testing Instructions
1.Open the template files
2.Select a file and click into the editor
3.Go to full-screen editor
Expected result
Editor menu above the file contents
Actual result
Editor menu overlaps the top few lines of the file being edited and it's not possible to see these lines. If the screen is narrowed a bit the editor menu moves down a couple of lines
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
Without even testing it, this will not allow modals to function correctly (modals have a z-index of 1050 iirc). Thus your index should be something less than 1050. Now if you are wondering how the heck can I get a modal there? Well, I did a PR which moved the XTD-buttons inside the Codemirror so even in full screen those could be accessible. Some folks didn't even realise why I was doing it and they close it down. So effectively full screen in Codemirror, even in J4, is still not fully usable.
Thus your index should be something less than 1050.
@dgrammatiko what should be the z-index then according to you ?
@hardik-codes check the z-indexes: https://github.com/twbs/bootstrap/blob/f2d33cd86b2bc21fba9078e6d0955f5308494ec1/scss/_variables.scss#L672-L684
it needs to be something reasonable. Maybe you have to set also the z-index in codeMirror. Anyways the value 1200 is WAY to high
@dgrammatiko I made the z-index to 1200 as per #23512 (comment)
@hardik-codes my comment was: something like. Did you take that comment literally? You need to do some research on the possible side effects before proposing a solution. You didn't, and I'm pointing out here that this value will break, tooltips, popovers and modals all of them could be initiated when the editor is on fullscreen mode...
@Scrabble96 as Issue opener please test.
| Category | Repository NPM Change | ⇒ | Repository |
Very sorry not to respond sooner @franz-wohlkoenig
How do I test this? Other than the comments I made on the bottom of the post by @ciar4n on 31st March.
Is there still anything to test? There's a message saying "This branch is out-of-date with the base branch". I don't know what that means, exactly.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-03 18:24:19 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Labels |
Removed:
J4 Issue
|
||
| Category | Repository | ⇒ | Repository NPM Change |
@dgrammatiko @Scrabble96 please test