[#24423] - [4.0] redesigned media-browser-actions-list
- Closed
- 4 Jun 2019
- Medium
- Build: 4.0-dev
- # 24423
- Diff
- bahl24:fix#567-media-manager
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #joomla-projects/media-manager-improvement#567.
Will also help to solve #23968
Summary of Changes
Small changes in actions - list
Testing Instructions
Build vue files & clear cache.
This Pull Request can only be tested by NPM only on a local environment and not by using Patchtester.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_media NPM Change |
| Title |
|
||||||
| Title |
|
||||||
is this Test using Patchtester?
I did style the original media manager UI for the old template design but I'm not part of the @rdeutz template group. Last I checked that group was private. So short answer.. I don't know.
IMO since the template design has changed, the media manager looks out of place with the rest of the template and needs a total overhaul. But any changes is probably pointless IF this is been worked elsewhere.
@franz-wohlkoenig Not possible to test with patchtester
@ciar4n thanks, can you please provide a Link how to use NPM? Haven't found at https://docs.joomla.org/Special:MyLanguage/Portal:Joomla!_Code_Contributors
Follow the link in the reader for j4 which takes you to
https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment
You can only do this on a local environment. It is not possible on a remote like launch.joomla.org
@franz-wohlkoenig you can run npm run dev in administrator/components/com_media folder & then clear browser cache after applying the patch.
@brianteeman thanks for Links and Info.
I updated the Test Instructions so non-Dev know how to test. If this is fine, i would append this Informations on all PR which need NPM for test.
@ciar4n it's public now ;) https://github.com/joomla/backend-template/tree/release (make sure you're on the release branch if you clone down). but no they haven't worked on the media manager
| Category | Administration com_media NPM Change | ⇒ | Administration com_media |
I don't think this is going to be acceptable from an a11y perspective @brianteeman @zwiastunsw as i assume all the elements need to be in the same ul element
@wilsonge thats correct but it can be resolved very easily - you can display a single list in two columns with just css using the html5 columns styling https://www.w3.org/TR/css-multicol-1/
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-04 22:45:38 |
| Closed_By | ⇒ | Quy |
| Closed_Date | 2019-06-04 22:45:38 | ⇒ | 2019-06-04 22:45:39 |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24423
Closing in favor of #25123
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24423.
Closing in favor of #25123
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24423.
| Category | Administration com_media | ⇒ | Administration com_media NPM Change |
New display works here. Is it what admin template workgroup desires? @ciar4n