J4 Issue ? Success

User tests: Successful: Unsuccessful:

avatar Arpit-24
Arpit-24
30 Mar 2019

Pull Request for Issue #23807 .

Summary of Changes

Change flex-end to flex-start to align to the left side

Testing Instructions

administrator/index.php?option=com_modules&view=modules

Expected result

Screenshot (1273)
Screenshot (1274)

avatar Arpit-24 Arpit-24 - open - 30 Mar 2019
avatar Arpit-24 Arpit-24 - change - 30 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2019
Category Administration Templates (admin)
avatar infograf768
infograf768 - comment - 31 Mar 2019

Not sure I understand.
What are you trying to solve?
I can't reproduce #23807 here (Firefox) whether I use flex-start or flex-end. The client is always floating as should (depending if lang is ltr or rtl).

avatar infograf768
infograf768 - comment - 31 Mar 2019

Oh, this concerns specially IE11...
I modify the title.

avatar infograf768 infograf768 - change - 31 Mar 2019
Title
[4.0] Fix Client dropdown mis-alignment
[4.0] [IE11] Fix Client dropdown mis-alignment
avatar infograf768 infograf768 - edited - 31 Mar 2019
avatar Arpit-24
Arpit-24 - comment - 1 Apr 2019

You will also need to ensure it works on RTL

Tested by changing the html tag attribute dir from ltr to rtl. While not really a pleasure to look at but the same behavior is exhibited by both Chrome and IE11 so I think it works.

Screenshot (1277)
Screenshot (1276)

avatar infograf768
infograf768 - comment - 1 Apr 2019

To test rtl, please install the Persian language and use it in back-end.
One gets this (as the pack is 3.x, are missing some lang strings and en-GB string are used)

Screen Shot 2019-04-01 at 11 34 33

avatar infograf768 infograf768 - change - 1 Apr 2019
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Apr 2019

@C-Lodder as Issue opener please test.

avatar C-Lodder
C-Lodder - comment - 4 Apr 2019

If @infograf768 is happy with the RTL result, I approve based on code review.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[4.0] [IE11] Fix Client dropdown mis-alignment
[4.0] Fix Client dropdown mis-alignment
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar Quy
Quy - comment - 19 Apr 2019

This is no longer an issue with the new backend template.

24421

24421rtl

avatar Quy Quy - change - 19 Apr 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-04-19 18:15:43
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 19 Apr 2019
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 19 Apr 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 19 Apr 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24421

Add a Comment

Login with GitHub to post a comment