? ? Failure

User tests: Successful: Unsuccessful:

avatar acs-ferreira
acs-ferreira
29 Mar 2019

Summary of Changes

Load external script with async/defer (as invisble reCaptcha already does):

https://github.com/joomla/joomla-cms/blob/staging/plugins/captcha/recaptcha_invisible/recaptcha_invisible.php#L84

avatar acs-ferreira acs-ferreira - open - 29 Mar 2019
avatar acs-ferreira acs-ferreira - change - 29 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2019
Category Front End Plugins
avatar C-Lodder
C-Lodder - comment - 29 Mar 2019

defer and async?

Are you sure you know what these attributes do?

avatar acs-ferreira
acs-ferreira - comment - 29 Mar 2019

https://www.w3.org/TR/2011/WD-html5-20110525/scripting-1.html#attr-script-async

The defer attribute may be specified even if the async attribute is specified, to cause legacy Web browsers that only support defer (and not async) to fall back to the defer behavior instead of the synchronous blocking behavior that is the default.

https://developers.google.com/recaptcha/docs/display

image

avatar acs-ferreira acs-ferreira - change - 29 Mar 2019
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 29 Mar 2019

@acs-ferreira Last I heard, async has a higher priority than defer so it would always be used instead. Then defer would be used if the browser didn't support async

avatar acs-ferreira
acs-ferreira - comment - 29 Mar 2019

@C-Lodder agree. And it seems that W3C also agrees on that! So we both agree 🎉 💃

avatar HLeithner
HLeithner - comment - 2 Apr 2019

Can you please rebase this PR on j4 branch.

avatar twister65
twister65 - comment - 14 Apr 2019

When you want to validate an ajax form with a 3rd-party extension, recaptcha is not loaded at all.
Defers activation of the recaptcha widget to the behavior should resolve that. See:
https://www.drupal.org/project/recaptcha/issues/2493183

avatar hardik-codes
hardik-codes - comment - 14 Apr 2019

Can you please rebase this PR on j4 branch.

@HLeithner may I do a separate PR for J4?

avatar HLeithner
HLeithner - comment - 14 Apr 2019

Can you please rebase this PR on j4 branch.

@HLeithner may I do a separate PR for J4?

yes a new pr would work better for you

avatar brianteeman
brianteeman - comment - 14 Apr 2019

Pretty sure that the reason for asking if it could be a separate PR was so that this one could also be merged in j3

avatar HLeithner
HLeithner - comment - 14 Apr 2019

oh, if this is the case no, because commits to j3 get merged to j4 by george at the moment.

avatar brianteeman
brianteeman - comment - 14 Apr 2019

which is why I didnt understand the request to rebase

avatar hardik-codes
hardik-codes - comment - 14 Apr 2019

@brianteeman @HLeithner is a separate PR needed?

avatar HLeithner
HLeithner - comment - 14 Apr 2019

I missed that this is a bug fix and not a "feature". @hardik-codes forget the rebase or another pr we only need 2 successful tests and I can merge it.

avatar hardik-codes
hardik-codes - comment - 14 Apr 2019

Ok
Thanks for the info

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Apr 2019

@acs-ferreira can you please give Test Instructions in first Comment? Maybe we get then Tests.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2019

@acs-ferreira can you please give Test Instructions in first Comment? Maybe we get then Tests.

closed due the lack of response.

avatar franz-wohlkoenig franz-wohlkoenig - close - 20 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jul 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-07-20 08:04:39
Closed_By franz-wohlkoenig
Labels Added: ?

Add a Comment

Login with GitHub to post a comment