Feeling Lucky
?
?
[#24379] - Add Edge (chromium) support
- Fixed in Code Base
- 23 Apr 2019
- Medium
- Build: staging
- # 24379
- Diff
- 810:edgestage
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
no test
Pull Request for Issue # .
Summary of Changes
add support new edge
Testing Instructions
code review
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
?
|
||
810
- comment
- 28 Mar 2019
fixed the codestyle
Quy
- comment
- 1 Apr 2019
How about using existing code to handle the new version as follows:
if (preg_match('|Edg(e)?\/([0-9.]+)|', $this->agent, $version))
{
$this->setBrowser('edg' . $version[1]);
if (strpos($version[2], '.') !== false)
{
list($this->majorVersion, $this->minorVersion) = explode('.', $version[2]);
}
else
{
$this->majorVersion = $version[2];
$this->minorVersion = 0;
}
}
810
- comment
- 1 Apr 2019
if (preg_match('|Edg(e)?\/([0-9.]+)|', $this->agent, $version))
Edge will stay at 2 different versions <75 Will be the edge html, and above 75 will use the blink html.
Quy
- comment
- 1 Apr 2019
$this->setBrowser('edg' . $version[1]);
It will be set to edge or edg accordingly.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-23 16:56:30 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Removed:
J3 Issue
|
||
HLeithner
- comment
- 23 Apr 2019
thx
For completeness, joomla-framework/application#86 added the same for the
Joomla\Application\Web\WebClientclass and I went ahead and tagged a new release with that included. So if someone wants to do thecomposer updatethen both browser detection libraries will have this addition once this PR and the upstream change are applied.