Feeling Lucky
?
?
[#24365] - [4.0] Move csp configuration to the com_csp component
- Fixed in Code Base
- 20 Apr 2019
- Medium
- Build: 4.0-dev
- # 24365
- Diff
- zero-24:move_csp_config
- Success Hound No violations found. Woof! Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Summary of Changes
Move csp configuration to the com_csp component
Testing Instructions
configure the http headers using com_csp's options make sure all is still working as expected
Expected result
csp configs are just moved and all features still work
Actual result
csp config is in the plugin but we now have a component so the options get moved
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_csp Language & Strings Front End Plugins |
| Labels |
Added:
?
?
|
||
zero-24
- comment
- 27 Mar 2019
Agree but IIRC there is no way to do this for strings in the XML files right?
brianteeman
- comment
- 27 Mar 2019
Sorry I forgot these were in the xml
franz-wohlkoenig
- | Category | Administration com_csp Language & Strings Front End Plugins | ⇒ | Administration com_csp Front End Plugins |
| Labels |
Removed:
J4 Issue
|
||
| Category | Administration com_csp Front End Plugins | ⇒ | Administration com_csp Language & Strings Front End Plugins |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-20 21:25:03 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 20 Apr 2019
Thanks!
I think that instead of having the comments in the language strings we should adopt the method used in the installer and use sprintf so the strings dont contain the links and terms that should not be translated