J3 Issue ? ? Success

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
25 Mar 2019

Pull Request for Issue #24344 .

Summary of Changes

In firefox menus are been split across columns in the template menu assignment tab

Testing Instructions

Have less than 4 menus. Navigate to template style menu assignment tab. Note if using sample data, it is probably easier to just delete the extra li nodes to display less than 4 menus (browser tools).

Before

image

After

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 25 Mar 2019
avatar ciar4n ciar4n - change - 25 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2019
Category Administration Templates (admin)
avatar ciar4n ciar4n - change - 25 Mar 2019
Labels Added: ?
avatar HLeithner
HLeithner - comment - 2 Apr 2019

You have to update the css file.

avatar ciar4n
ciar4n - comment - 2 Apr 2019

My bad. LESS has been compiled.

Im getting mixed up with 4. I guess this can be tested with patchtester.

avatar ciar4n ciar4n - change - 2 Apr 2019
The description was changed
avatar ciar4n ciar4n - edited - 2 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[Firefox] Fix page-break-inside (template menu assignment)
Fix page-break-inside (template menu assignment)
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Apr 2019
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Apr 2019

I have tested this item successfully on a993dea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24345.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Apr 2019

I have tested this item successfully on a993dea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24345.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Apr 2019 - Tested successfully
avatar alikon
alikon - comment - 26 Apr 2019

I have tested this item successfully on a993dea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24345.

avatar alikon alikon - test_item - 26 Apr 2019 - Tested successfully
avatar alikon alikon - change - 26 Apr 2019
Status Pending Ready to Commit
Labels
avatar alikon
alikon - comment - 26 Apr 2019

Status "Ready To Commit".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24345.

avatar HLeithner HLeithner - change - 26 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-26 10:04:13
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 26 Apr 2019
avatar HLeithner HLeithner - merge - 26 Apr 2019
avatar HLeithner
HLeithner - comment - 26 Apr 2019

thx

avatar ciar4n
ciar4n - comment - 26 Apr 2019

@franz-wohlkoenig @alikon thank you for the tests

Add a Comment

Login with GitHub to post a comment