[#24340] - [4.0] setting icon now accessible
- Fixed in Code Base
- 16 Apr 2019
- Medium
- Build: 4.0-dev
- # 24340
- Diff
- bahl24:fix#24235
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #24325 .
Summary of Changes
Added empty href attribute for settings icon & unpublish option in dropdown
Testing Instructions
Go to Control Panel.
Tab through whole page using keyboard.
Expected result
Setting Icon & unpublish option of all Administrator Modules (Sample Data, Logged-in Users etc.) can be selected for keyboard only users via TAB.
Actual result
Not able to select Setting icon & unpublish option through keyboard.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
it should be handled exactly the same as any dropdown menu item
@zwiastunsw @brianteeman i would assume these should be buttons. But before I give the word could one of you two confirm please
It should be a button, not a link. Setting a with href="#" attribute is incorrect.
No problem, let me change them to button and not links
lgtm
| Labels |
Removed:
J4 Issue
|
||
@wilsonge @zwiastunsw Kindly test
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-16 14:21:54 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I think this is another one of these places it should be a button instead of a link - because it's just opening the dropdown