Joomla! Issue Tracker | Joomla! CMS #24322

Fixed in Code Base
23 Apr 2019
Medium
Build: 4.0-dev
# 24322
Diff
brianteeman:legend

Pending

Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
Success continuous-integration/drone/pr the build was successful Details
Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

brianteeman
23 Mar 2019

The style for the legend class used in global configuration and extensions-install is the same as the field labels so it doesnt stand out.

Changing the $normal-weight to $bold-weight fixes that

###Testing
Requires npm i

Before

After

59fc652 23 Mar 2019

[4.0] Legend in bold

brianteeman - open - 23 Mar 2019

brianteeman - change - 23 Mar 2019

Status

New

⇒

Pending

joomla-cms-bot - change - 23 Mar 2019

Category

⇒

Administration Templates (admin)

Quy - comment - 23 Mar 2019

I have tested this item ✅ successfully on 59fc652

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24322.}

Quy - test_item - 23 Mar 2019 - Tested successfully

ciar4n - comment - 23 Mar 2019

As you are reverting #23927, you can remove the font-weight rather than changing it.

brianteeman - comment - 23 Mar 2019

@ciar4n will do. Your pr shouldnt have been merged (not your fault) - it was too generic

dd3fd50 23 Mar 2019

Update _form.scss

brianteeman - change - 23 Mar 2019

Labels

Added: ?

ciar4n - comment - 24 Mar 2019

If #23927 is still required you can move the font weight and size inside a .control-group legend selector.

.control-group legend {
  font-size: 1rem;
  font-weight: $normal-weight;
}

If not then leave as it.

brianteeman - comment - 24 Mar 2019

Thanks for the tip - its not needed yet as the switcher code hasnt been changed yet

416cc73 25 Mar 2019

Merge branch '4.0-dev' into legend

3bc743d 29 Mar 2019

Merge branch '4.0-dev' into legend

Quy - comment - 29 Mar 2019

I have tested this item ✅ successfully on 3bc743d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24322.}

Quy - comment - 29 Mar 2019

I have tested this item ✅ successfully on 3bc743d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24322.}

Quy - test_item - 29 Mar 2019 - Tested successfully

brianteeman - comment - 21 Apr 2019

@wilsonge can this get merged please - its a simple revert

95b9e01 22 Apr 2019

Merge branch '4.0-dev' into legend

HLeithner - change - 22 Apr 2019

Labels

Removed: J4 Issue

c09aead 23 Apr 2019

Merge branch '4.0-dev' into legend

wilsonge - comment - 23 Apr 2019

What's going on with the originally proposed code in #23888 because originally this was done for that.

wilsonge - change - 23 Apr 2019

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2019-04-23 09:19:48
Closed_By		⇒	wilsonge

wilsonge - close - 23 Apr 2019

wilsonge - change - 23 Apr 2019

Status	Closed	⇒	New
Closed_Date	2019-04-23 09:19:48	⇒
Closed_By	wilsonge	⇒

wilsonge - change - 23 Apr 2019

Status

New

⇒

Pending

wilsonge - reopen - 23 Apr 2019

brianteeman - comment - 23 Apr 2019

That was jumping the gun. Current work is in #24463

wilsonge - close - 23 Apr 2019

wilsonge - merge - 23 Apr 2019

wilsonge - change - 23 Apr 2019

Status	Pending	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2019-04-23 10:10:01
Closed_By		⇒	wilsonge

brianteeman - comment - 23 Apr 2019

thanks

wilsonge - comment - 23 Apr 2019

Makes sense. Thanks!

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#24322] - [4.0] Legend in bold

Before

After

Add a Comment