[#24298] - Random Image module
- Closed
- 4 Jul 2019
- Medium
- Build: master
- # 24298
What needs to be fixed
In the Random Image Module, there is a line that sets the default width to 100 if the user enters no width.
if ($width == '')
{
$width = 100;
}
I'm assuming the intended functionality is to set the default width to 100%, however this code is ambiguous and get's interpreted as 100px in Chrome.
Why this should be fixed
Errors like this build up and ambiguous code is bad in general.
How would you fix it
if ($width == '')
{
$width = "100%";
}
Side Effects expected
Images that users are used to being small will become responsive.
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Information Required |
The field in the random image module config is a number type input and it defaults to 100. It is clearly labled 'px'.
This is not an error just very limited in its functionality. The module was written in a time prior to responsiveness.
| Status | Information Required | ⇒ | Discussion |
| Category | ⇒ | com_modules |
Members is this issue already resolved as suggested by @JamesNGarrett ?
I'd be more than happy to update the plugin with responsiveness if it's cool for me to contribute that kind of change? I'm pretty sure I could make it backwards compatible pretty easily.
if this is for j3 calling @HLeithner
"Adding functionality" has to go to J4.
"Fixing bug" (without changing functionality) can go into J3.
"Adding functionality" has to go to J4.
"Fixing bug" (without changing functionality) can go into J3.
Truth but devo for my employer. I've already patched up their J3 implementation with a workaround so it's not a problem anyway.
I'll add this to J4 then and do a pull request, cheers.
| Labels |
Added:
J3 Issue
|
||
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-04 07:55:10 |
| Closed_By | ⇒ | joomla-cms-bot |
| Closed_By | joomla-cms-bot | ⇒ | alikon |
Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/24298
managed in #22068
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24298.
managed in #22068
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24298.
Thanks for your Suggest, can you make a Pull Request against J4?