No Code Attached Yet J4 Issue
avatar wilsonge
wilsonge
21 Mar 2019

com_config is looser at validating the database name than the installer (which was patched as part of #23704). This should be normalised using a standard validation filter for JForm

avatar wilsonge wilsonge - open - 21 Mar 2019
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Mar 2019
avatar wilsonge wilsonge - change - 21 Mar 2019
Title
Consistent validation of the database name
[4.0] Consistent validation of the database name
avatar wilsonge wilsonge - edited - 21 Mar 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Mar 2019
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Mar 2019
Category com_config
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar jwaisner jwaisner - change - 24 Mar 2020
Status Discussion New
Build staging 4.0-dev
avatar joomdonation joomdonation - close - 14 Nov 2022
avatar joomdonation
joomdonation - comment - 14 Nov 2022

From what I see, that kind of validation is nice to have but not needed anymore. The reason is because before the change is saved, we even try to connect to database to see if it works before saving the change.

With that said, I'm closing this issue for now. Please re-open it if you still want to have this validation rule implemented.

avatar joomdonation joomdonation - change - 14 Nov 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-11-14 10:51:05
Closed_By joomdonation
Labels Added: No Code Attached Yet
Removed: ?
avatar wilsonge wilsonge - change - 14 Nov 2022
Status Closed New
Closed_Date 2022-11-14 10:51:05
Closed_By joomdonation
avatar wilsonge wilsonge - reopen - 14 Nov 2022
avatar wilsonge
wilsonge - comment - 14 Nov 2022

I do want it because it's more about the security of what we are validating before trying to connect than whether it works or not

avatar alikon alikon - close - 19 Feb 2023
avatar alikon
alikon - comment - 19 Feb 2023

plesase test #39889

avatar alikon alikon - change - 19 Feb 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-02-19 11:07:39
Closed_By alikon
avatar alikon alikon - change - 10 Apr 2024
Status Closed New
Closed_Date 2023-02-19 11:07:39
Closed_By alikon
avatar alikon alikon - reopen - 10 Apr 2024

Add a Comment

Login with GitHub to post a comment