[#24284] - [4.0] Add missing XML files for Admin Menu creation
- Fixed in Code Base
- 19 Oct 2019
- Medium
- Build: 4.0-dev
- # 24284
- Diff
- drmenzelit:new-xml
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Success Hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr the build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Added several xml files for admin components to be able to create new menu items in admin menus
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_csp com_fields com_finder com_menus com_messages com_workflow Language & Strings |
In my last commit I added a parameter on the files for fields to choose the correct component. The new file administrator/components/com_menus/Field/ComponentsfieldsField.php does the work (at least on my tests) :-)
| Title |
|
||||||
| Title |
|
||||||
Selecting the component which use fields is not clear. There is no flag for "this component uses fields".
So the field selects components with param "custom_fields_enable":"1" .
After a fresh installation, only com_contact has set this parameter so other components, also com_content or com_users are not in the list.
We could change the install files, so that at least all core components have this parameter. But for 3rd party components?
| Category | Administration com_csp com_fields com_finder com_menus com_messages com_workflow Language & Strings | ⇒ | Administration com_csp com_fields com_finder com_menus com_messages com_workflow |
Please resolve conflicting files so this PR can get tested at Worldwide Pizza, Bugs & Fun, October 19th
| Labels |
Added:
Conflicting Files
?
|
||
| Category | Administration com_csp com_fields com_finder com_menus com_messages com_workflow | ⇒ | Administration com_csp com_fields com_finder com_menus com_messages com_workflow Language & Strings |
@franz-wohlkoenig I really hope it can be fixed and merged before then
I have commited the suggested changes, I resolved the conflict on the language file and actualized my branch. I hope, it was correct and now the PR can be tested.
I have tested this item
New menu items:
- Content Security Policy
-> List All Content Security Policy Reports - Messaging
-> List all Messages - Smart Search
-> Smart Search Content Mapping
-> Smart Search Filters
-> Smart Search Indexed Content
-> Smart Search results
-> Smart Search Statistics - Workwlows
-> List All Workflows
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24284.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24284.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24284.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-19 14:29:39 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
Removed: ? |
||
Thanks!
Do the fields views not need to have a component specified?