? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
21 Mar 2019

Pull Request for Issue #24264

Summary of Changes

Taking of the duplicate div displaying the Language field when using batch language for site modules.
Correcting cs (spaces instead of tabs)

Testing Instructions

Load Modules Manager. Select a module. Click on the Batch button.

Before patch

Screen Shot 2019-03-21 at 09 11 39

After patch

Screen Shot 2019-03-21 at 09 10 35

avatar infograf768 infograf768 - open - 21 Mar 2019
avatar infograf768 infograf768 - change - 21 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2019
Category Administration com_modules
avatar infograf768
infograf768 - comment - 21 Mar 2019

Beware

this should be tested on a clean install of the 4.0 branch as there were changes in db yesterday for com_modules.

avatar infograf768 infograf768 - change - 21 Mar 2019
Title
[4.0] [com_mdules] Batch language broken
[4.0] [com_modules] Batch language broken
avatar infograf768 infograf768 - edited - 21 Mar 2019
avatar brianteeman
brianteeman - comment - 21 Mar 2019

I have tested this item ? unsuccessfully on 1010e35

Tested on a completely clean install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24273.
avatar brianteeman
brianteeman - comment - 21 Mar 2019

I have tested this item ? unsuccessfully on 1010e35

Tested on a completely clean install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24273.
avatar brianteeman brianteeman - test_item - 21 Mar 2019 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 21 Mar 2019

It works perfectly here. No idea why it does not for you.

avatar brianteeman
brianteeman - comment - 21 Mar 2019

Clean install with french installed and the multilingual setup plugin is failing exactly as I saw yesterday when I tried the same change

Site

image

Admin

image

avatar infograf768
infograf768 - comment - 21 Mar 2019

S0:
For site it is fine, your result is now OK.
For admin It does not depend on the multilingual setting at all. It works also for monolingual sites as it only depends on the installed admin languages and not content languages.

You do not get a Language field in your screenshot and this is correct if you have not set in com_modules Options the Language Filtering to YES
Screen Shot 2019-03-21 at 10 02 58

avatar brianteeman
brianteeman - comment - 21 Mar 2019

I knew there was something I must have forgotten to do :)

avatar brianteeman
brianteeman - comment - 21 Mar 2019

I have tested this item successfully on 1010e35

Tested on a completely clean install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24273.
avatar brianteeman brianteeman - test_item - 21 Mar 2019 - Tested successfully
avatar wilsonge wilsonge - change - 21 Mar 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-21 13:35:13
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 Mar 2019
avatar wilsonge wilsonge - merge - 21 Mar 2019
avatar wilsonge
wilsonge - comment - 21 Mar 2019

Thanks!

Add a Comment

Login with GitHub to post a comment