Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24264] - [4.0] Modules batch language

?
avatar brianteeman
brianteeman
20 Mar 2019

there has been a change in
joomla-cms/administrator/components/com_modules/tmpl/modules/default_batch_body.php
since joomla 3

It looks like it was an attempt to fix an issue whereby the language option didnt appear when a site had multiple admin languages installed but its not correct as it results in two language selectors when batch changing site modules.

From my tests the third instance of the language selector needs to be removed and that the problem is that this code is never evaluating as true and that is the real bug

$clientId == 1 && ModuleHelper::isAdminMultilang

avatar brianteeman brianteeman - open - 20 Mar 2019
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Mar 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Mar 2019
Status New ⇒ Discussion
avatar infograf768
infograf768 - comment - 21 Mar 2019

The issue is a duplicate.
$clientId == 1 && ModuleHelper::isAdminMultilang is evaluated as true when param is set to yes

        <div class="form-group col-md-6">
			<div class="controls">
				<?php echo LayoutHelper::render('joomla.html.batch.language', []); ?>
			</div>
		</div>

making patch now

avatar brianteeman
brianteeman - comment - 21 Mar 2019

It should be that's correct but my test of that didn't work. Maybe I missed something but I tried for a while.

avatar infograf768
infograf768 - comment - 21 Mar 2019

Please test
#24273
Closing as we have a patch.

avatar infograf768 infograf768 - change - 21 Mar 2019
Status Discussion ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-03-21 08:15:15
Closed_By ⇒ infograf768
avatar infograf768 infograf768 - close - 21 Mar 2019

Add a Comment

Login with GitHub to post a comment