? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
20 Mar 2019

Pull Request for Issue #23756 (comment)

Summary of Changes

Modified EOL to Unix for the confirm-delete-modal.vue file
Changed the specific strings from _MODEL_ to _MODAL_
Use the global string JGLOBAL_CONFIRM_DELETE instead of the new COM_MEDIA_CONFIRM_DELETE_MODEL_DESC

Testing Instructions

Patch. Run npm ci

After patch

Load the media manager. Select an item and click on the Delete button.
The modal will now look like this:

Screen Shot 2019-03-20 at 08 01 21

@Anu1601CS

avatar infograf768 infograf768 - open - 20 Mar 2019
avatar infograf768 infograf768 - change - 20 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2019
Category Administration com_media NPM Change Language & Strings
avatar infograf768 infograf768 - change - 20 Mar 2019
Labels Added: ? NPM Resource Changed ?
avatar infograf768 infograf768 - change - 20 Mar 2019
The description was changed
avatar infograf768 infograf768 - edited - 20 Mar 2019
avatar infograf768 infograf768 - change - 20 Mar 2019
The description was changed
avatar infograf768 infograf768 - edited - 20 Mar 2019
avatar wilsonge wilsonge - change - 20 Mar 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-20 11:23:46
Closed_By wilsonge
avatar wilsonge wilsonge - close - 20 Mar 2019
avatar wilsonge wilsonge - merge - 20 Mar 2019
avatar wilsonge
wilsonge - comment - 20 Mar 2019

Looks good to me - thanks!

Add a Comment

Login with GitHub to post a comment