Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#2425] - Fix limits in JDatabaseQuery

?

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
6 Nov 2013

Fix here: http://www.joomlaportal.de/joomla-2-5-installation/303554-sammelthread-joomla-2-5-15-a-3.html#post1499731

and tested on forums here: http://forum.joomla.org/viewtopic.php?f=615&t=825307

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32556&start=0

avatar wilsonge wilsonge - open - 6 Nov 2013
avatar mbabker
mbabker - comment - 6 Nov 2013

That's not right. $this->sql is referring to a query, so it should either be a query string or an instance of JDatabaseQuery. 2.5 doesn't have the JDatabaseQueryLimitable interface, so that's not an option here.

avatar GJSchaller
GJSchaller - comment - 6 Nov 2013

Don't forget mysqli.php, too!

avatar mbabker
mbabker - comment - 6 Nov 2013

The right fix is to remove the $this->sql checks in the MySQL(i) drivers. The SQL Server driver can be left as is shipped in 2.5, there's some 3.x logic backported that makes that check valid.

avatar Kubik-Rubik
Kubik-Rubik - comment - 6 Nov 2013

Yes, we can just use the files from the version 2.5.14 to "fix" this issue!

avatar wilsonge
wilsonge - comment - 6 Nov 2013

Looking better Michael?

avatar mbabker
mbabker - comment - 6 Nov 2013

YES!

avatar mbabker mbabker - reference | - 6 Nov 13
avatar wilsonge
wilsonge - comment - 6 Nov 2013

Closing as fixed by michael in 6d185fb - although not sure why this hasn't autoclosed - perhaps a github bug?

avatar wilsonge wilsonge - close - 6 Nov 2013
avatar wilsonge wilsonge - head_ref_deleted - 6 Nov 2013
avatar gbatuyong
gbatuyong - comment - 6 Nov 2013

Thank you very much @wilsonge whew! Good job on spotting the cause and fixing it quickly.

avatar Kubik-Rubik
Kubik-Rubik - comment - 6 Nov 2013

You are welcome, @gbatuyong ;-)

Add a Comment

Login with GitHub to post a comment