[#24230] - Add minimum lowercase rule for password validation.
- Fixed in Code Base
- 22 Mar 2019
- Medium
- Build: staging
- # 24230
- Diff
- HLeithner:add-lowercase-password-check
User tests: Successful: Unsuccessful:
Pull Request for Issue #24156 .
Summary of Changes
Add missing lower case requirement for passwords
Testing Instructions
Set minimum lowercase count to 0 or higher.
Change password. Use password with more and less lowercase characters
Expected result
It should be possible to force a minimum of lowercase characters.
Actual result
Option is missing.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings Libraries |
I just realised that too ;)
I don't care if we use one word or two but we should be consistent - especially in the same sentence. Should help the translators as well
| Labels |
Added:
?
?
|
||
Tested with Joomla! Patch Tester and it works fine
I have tested this item
Hello, I've test with one and with more than one lower case
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
I've just do it Franz, I'm a new tester... :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
I've just do it Franz, I'm a new tester... :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
@HLeithner you need to reflect these changes here: https://github.com/joomla/joomla-cms/blob/staging/media/system/js/passwordstrength.js
A fair warning tho, that file is Mootools based so in essence wouldn't be advisable to ask anyone to add any new functionality there. In short better do this in the 4.0 repo...
This is already available in j4
This is already available in j4
Well I lost track of the things I did already for J4
Anyways, then at a bare minimum, the last function in the Mootools version needs to be adapted
@dgrammatiko this file looks like its only show the password strength and doesn't have anything to do with the requirement.
@HLeithner it should read the requirements for calculating the strength, or maybe not...
The script uses the threshold that is set as parameter I didn't find any calculation based on the requirements parameters...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
If I add the name spaces here I have to change the complete file and I think this would maybe give a merge conflict when george merge it into 4.0
J4 already has a lowercase rule
maybe it's me but the 4.0 https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Form/Rule/PasswordRule.php didn't have lowercase yet....
@HLeithner not an expert on "easy merging" matter but looking the 2 file side by side ....
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-22 11:14:03 |
| Closed_By | ⇒ | wilsonge |
I did a copy of the uppercase sentence,.. should be changed too?