? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
18 Mar 2019

Pull Request for Issue #24208

Summary of Changes

Adding $noUser option to contacts batch

Testing Instructions

Display the Contacts Manager.
Select a contact and click on batch.

Before patch

When displaying the manager we get a Notice:
[16-Mar-2019 17:38:22 Europe/Berlin] PHP Notice: Undefined variable: noUser in ROOT/layouts/joomla/html/batch/user.php on line 26

After selecting a contact and using the batch button, the "No User.` option is not displayed.
Screen Shot 2019-03-18 at 09 07 18

After patch

No more Notice.
The option is displayed.
Screen Shot 2019-03-18 at 09 39 38

WARNING: this is uncomplete

Selecting No user. in the modal and saving thows an error:

Screen Shot 2019-03-18 at 09 46 02

avatar infograf768 infograf768 - open - 18 Mar 2019
avatar infograf768 infograf768 - change - 18 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Mar 2019
Category Administration com_contact
avatar infograf768 infograf768 - change - 18 Mar 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 18 Mar 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-18 10:23:14
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Mar 2019
avatar wilsonge wilsonge - merge - 18 Mar 2019
avatar wilsonge
wilsonge - comment - 18 Mar 2019

I'll try and find some time to look a the error when selecting the option this evening. Merging this for now as a step in the right direction

avatar infograf768
infograf768 - comment - 18 Mar 2019

Maybe this would help:
I found out that the 0 $value is not obtained in
protected function batchUser($value, $pks, $contexts)

avatar infograf768
infograf768 - comment - 18 Mar 2019

Also, it looks like the file
default_batch.php is not used and maybe deleted

Add a Comment

Login with GitHub to post a comment