? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Mar 2019

Pull Request for Issue #23991

Summary of Changes

Make the category field readonly when editing an already saved article in frontend to solve confusion.
Such a modification without a new approval could create issues.

Testing Instructions

Edit an article in frontend

Before patch

Screen Shot 2019-03-17 at 11 04 45

After patch

Screen Shot 2019-03-17 at 10 36 02

Documentation Changes Required

avatar infograf768 infograf768 - open - 17 Mar 2019
avatar infograf768 infograf768 - change - 17 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2019
Category Administration com_content
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Mar 2019

@Milglius please test.

avatar Milglius
Milglius - comment - 20 Mar 2019

now it is ok , thank you

avatar infograf768
infograf768 - comment - 20 Mar 2019
avatar infograf768 infograf768 - change - 20 Mar 2019
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Mar 2019

@Milglius please mark your Test as successfully at Issue Tracker.

avatar Milglius
Milglius - comment - 22 Mar 2019

I have tested this item successfully on a9b46d9

tested OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24216.

avatar Milglius Milglius - test_item - 22 Mar 2019 - Tested successfully
avatar alikon
alikon - comment - 22 Mar 2019

I have tested this item successfully on a9b46d9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24216.

avatar alikon alikon - test_item - 22 Mar 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Mar 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Mar 2019

Status "Ready To Commit".

avatar infograf768 infograf768 - change - 22 Mar 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 22 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-22 08:13:30
Closed_By HLeithner
avatar HLeithner HLeithner - close - 22 Mar 2019
avatar HLeithner HLeithner - merge - 22 Mar 2019
avatar HLeithner
HLeithner - comment - 22 Mar 2019

thx

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Apr 2019

@ThomasK0lasa can you please explain your opinion in a friendly way?

avatar ThomasK0lasa
ThomasK0lasa - comment - 19 Apr 2019

Hello,

of course. I have large website which has 100 users which are used to change their category in case: they will make bad selection at first time, they want to change category of articles which goes to “archive” category different for each year. I also created them access to not publicly available “No category” where they can tweak their articles and then just change the category. So I understand that almost all of this can be done differently, but why remove a feature which is available for years?

Also I am not alone with this one: https://forum.joomla.org/viewtopic.php?t=971365

In my opinion bad decision which breaks backward compatibility. If this is needed for some people (I can understand) then just add an option to choose from and leave the old way. :) Something like “Allow Frontend category change after article creation” - true/false.

Sincerely,

Thomas

From: Franz Wohlkönig [mailto:notifications@github.com]
Sent: Friday, April 19, 2019 8:37 AM
To: joomla/joomla-cms
Cc: ThomasK0lasa; Mention
Subject: Re: [joomla/joomla-cms] [staging] category field readonly when editing an existing item in frontend (#24216)

@ThomasK0lasa https://github.com/ThomasK0lasa can you please explain your opinion in a friendly way?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #24216 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AEDX7CBNXSP5QTYH57WYF73PRFR7HANCNFSM4G7BFK3A . https://github.com/notifications/beacon/AEDX7CBO4ECFERGFYJPT3ZLPRFR7HANCNFSM4G7BFK3A.gif

avatar infograf768
infograf768 - comment - 19 Apr 2019

I do understand that this can be an issue for some.
Let me explain again the reasoning. See original issue.
The main problem are the limitations of Joomla ACL.
We can't separate modifications of the content of an article and its placement in another category.

The original issue is that an author, because he has edit.own permission, can modify the category (including creating a new one) AFTER the approval and publishing of the article.
Any of us can easily understand what kind of potential problems this can cause.

Example of what is already done to prevent some problems with Author's modifications in frontend by default in J:
Author can't set the article as featured.
Author can't modify Publishing dates.

This category change should be reserved to users with upper permissions, and if they remember in frontend the categories structure for the site.
Our ACL are not finetuned enough to define this limitation.
We would need to force a new approval/publish when such a change is done.

So we do have indeed an issue with this readonly patch if the author in frontend has created an article assigned to a specific category and a Publisher or upper wants to correct the category chosen by the author in frontend.

If this is needed for some people (I can understand) then just add an option to choose from and leave the old way. :) Something like “Allow Frontend category change after article creation” - true/false.

This is a clever proposal and can be done.
In the mean time you can easily revert this PR for your site.

avatar ThomasK0lasa
ThomasK0lasa - comment - 19 Apr 2019

I understand the reasoning why this was done. :)

I just don’t approve changing things in such way that they seem broken :D because this worked differently earlier.

Anyway, I reversed the code and it is ok for now. Have a nice weekend.

avatar infograf768
infograf768 - comment - 19 Apr 2019

We could, as done for featured and publishing, reserve category change to Publishers and up (still prone to errors imho), but better tuning.
Will propose PR for that.

avatar infograf768
infograf768 - comment - 19 Apr 2019

See #24640

avatar ron4mac
ron4mac - comment - 21 Apr 2019

Add me to the list of those who feel there needs to be an option with this. I have sites maintained by one or two 'maintainer' group users who are comfortable with frontend operations but would find the backend too confusing (speaking about confusion). No articles are created by anyone else. They like to change the category of an article to place it in somewhat of an archive situation.

avatar zero-24
zero-24 - comment - 21 Apr 2019

@ron4mac please check the PR #24640 by @infograf768

avatar infograf768
infograf768 - comment - 25 Apr 2019

@ron4mac
#24640 is now merged and will be available in 3.9.6.
Publishers and up (Therefore your "maintainers") will be able to modify the category in frontend.

Add a Comment

Login with GitHub to post a comment