? ? Pending

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
17 Mar 2019

Pull Request for Issue - Improved contrast and consistency for 'warning' label.

Testing

run node build.js --compile-css

Summary of Changes

Changed text color

Expected result

Screenshot from 2019-03-17 05-44-39

Actual result

Screenshot from 2019-03-17 06-03-23

Screenshot from 2019-03-17 09-24-28

avatar bahl24 bahl24 - open - 17 Mar 2019
avatar bahl24 bahl24 - change - 17 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2019
Category Installation
avatar bahl24 bahl24 - change - 17 Mar 2019
The description was changed
avatar bahl24 bahl24 - edited - 17 Mar 2019
avatar chmst
chmst - comment - 17 Mar 2019

@bahl24 good idea! But it is better not to use a color definition. Could you use the scss variable white instead?

avatar bahl24 bahl24 - change - 17 Mar 2019
Labels Added: ?
avatar bahl24
bahl24 - comment - 17 Mar 2019

@chmst I have changed, but I was wondering why is white better than its hex code?

avatar chmst
chmst - comment - 17 Mar 2019

Indeed, at this place it makes no difference, as the background here also is white and probably will not be changed. So thank you - I will test this asap.

avatar bahl24 bahl24 - change - 17 Mar 2019
The description was changed
avatar bahl24 bahl24 - edited - 17 Mar 2019
avatar bahl24
bahl24 - comment - 18 Mar 2019

@Quy Done

avatar Quy
Quy - comment - 19 Mar 2019

Actually lines 281-283 can be removed since the same class definition is defined starting at line 3420 in the generated template.css.

.badge-warning {
  color: #fff;
  background-color: #b35900; }
  a.badge-warning:hover, a.badge-warning:focus {
    color: #fff;
    background-color: #804000; }
  a.badge-warning:focus, a.badge-warning.focus {
    outline: 0;
    box-shadow: 0 0 0 0.2rem rgba(179, 89, 0, 0.5); }
avatar bahl24
bahl24 - comment - 19 Mar 2019

Actually lines 281-283 can be removed since the same class definition is defined starting at line 3420 in the generated template.css.

.badge-warning {
  color: #fff;
  background-color: #b35900; }
  a.badge-warning:hover, a.badge-warning:focus {
    color: #fff;
    background-color: #804000; }
  a.badge-warning:focus, a.badge-warning.focus {
    outline: 0;
    box-shadow: 0 0 0 0.2rem rgba(179, 89, 0, 0.5); }

Done

avatar chmst
chmst - comment - 19 Mar 2019

I have tested this item successfully on f2b231c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.

avatar chmst
chmst - comment - 19 Mar 2019

I have tested this item successfully on f2b231c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.

avatar chmst chmst - test_item - 19 Mar 2019 - Tested successfully
avatar Quy
Quy - comment - 19 Mar 2019

I have tested this item successfully on f2b231c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.

avatar Quy
Quy - comment - 19 Mar 2019

I have tested this item successfully on f2b231c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.

avatar Quy Quy - test_item - 19 Mar 2019 - Tested successfully
avatar Quy Quy - change - 19 Mar 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 19 Mar 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24213.

avatar wilsonge wilsonge - change - 21 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-21 12:58:53
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 21 Mar 2019
avatar wilsonge wilsonge - merge - 21 Mar 2019

Add a Comment

Login with GitHub to post a comment