User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_installer |
Labels |
Added:
?
|
I have tested this item
✅ successfully on a409779
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24210.
Do you want to match the code using $msg
and $msgType
as in \administrator\components\com_installer\models\install.php
?
// Install the package.
if (!$installer->install($package['dir']))
{
// There was an error installing the package.
$msg = JText::sprintf('COM_INSTALLER_INSTALL_ERROR', JText::_('COM_INSTALLER_TYPE_TYPE_' . strtoupper($package['type'])));
$result = false;
$msgType = 'error';
}
else
{
// Package installed successfully.
$msg = JText::sprintf('COM_INSTALLER_INSTALL_SUCCESS', JText::_('COM_INSTALLER_TYPE_TYPE_' . strtoupper($package['type'])));
$result = true;
$msgType = 'message';
}
From my point of view my code is clearer and it's approved already.
We have already a successful test and I don't want to waste time of valuable testers.
But like always: Take over if you want to and I close here. I don't want to waste too much time with a small change like this.
I only wait for a second test to merge.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-18 15:52:04 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
thx
I have tested this item✅ successfully on a409779
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24210.