? ? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
16 Mar 2019

Pull Request for Issue #24209

Testing Instructions

Expected result

  • Red error alert if extension update fails

Actual result

  • Message alert if update fails
avatar ReLater ReLater - open - 16 Mar 2019
avatar ReLater ReLater - change - 16 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2019
Category Administration com_installer
avatar ReLater ReLater - change - 16 Mar 2019
Labels Added: ?
avatar kofaysi
kofaysi - comment - 17 Mar 2019

I have tested this item successfully on a409779


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24210.

avatar kofaysi kofaysi - test_item - 17 Mar 2019 - Tested successfully
avatar kofaysi
kofaysi - comment - 17 Mar 2019

I have tested this item successfully on a409779
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24210.

image

avatar ReLater ReLater - change - 17 Mar 2019
The description was changed
avatar ReLater ReLater - edited - 17 Mar 2019
avatar Quy
Quy - comment - 18 Mar 2019

Do you want to match the code using $msg and $msgType as in \administrator\components\com_installer\models\install.php?

		// Install the package.
		if (!$installer->install($package['dir']))
		{
			// There was an error installing the package.
			$msg = JText::sprintf('COM_INSTALLER_INSTALL_ERROR', JText::_('COM_INSTALLER_TYPE_TYPE_' . strtoupper($package['type'])));
			$result = false;
			$msgType = 'error';
		}
		else
		{
			// Package installed successfully.
			$msg = JText::sprintf('COM_INSTALLER_INSTALL_SUCCESS', JText::_('COM_INSTALLER_TYPE_TYPE_' . strtoupper($package['type'])));
			$result = true;
			$msgType = 'message';
		}
avatar ReLater
ReLater - comment - 18 Mar 2019

From my point of view my code is clearer and it's approved already.
We have already a successful test and I don't want to waste time of valuable testers.
But like always: Take over if you want to and I close here. I don't want to waste too much time with a small change like this.

avatar ReLater ReLater - change - 18 Mar 2019
The description was changed
avatar ReLater ReLater - edited - 18 Mar 2019
avatar HLeithner
HLeithner - comment - 18 Mar 2019

I only wait for a second test to merge.

avatar Quy
Quy - comment - 18 Mar 2019

I have tested this item successfully on a409779


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24210.

avatar Quy Quy - test_item - 18 Mar 2019 - Tested successfully
avatar Quy Quy - change - 18 Mar 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Mar 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24210.

avatar Quy
Quy - comment - 18 Mar 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24210.

avatar HLeithner HLeithner - change - 18 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-18 15:52:04
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 18 Mar 2019
avatar HLeithner HLeithner - merge - 18 Mar 2019
avatar HLeithner
HLeithner - comment - 18 Mar 2019

thx

Add a Comment

Login with GitHub to post a comment