User tests: Successful: Unsuccessful:
Changed the update message (also made it a warning instead of a notice )so that users make backup before updating.
Code Inspection
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_installer com_joomlaupdate Language & Strings |
Ok then I'll close this
That is why there is a backlog. But it's a waste of resources to do things twice
Since naming convention for files have changed in J4
In J(3.x) we hadview.html.php
whereas in J4 we haveHtmlView.php
Will that not make merging difficult?
Depends on a lot of variables. If files were all moved with git's move command, its history usually does a pretty good job of saying "this file has been moved, so apply this segment of the diff to the new location instead". When things get too far diverged that's when you start running into problems with git not being able to sanely follow your renames. I've redone the folder structure on an application just as large as Joomla and thanks to carefully moving files when I needed to merge changes for the live production system into the in-progress refactoring I usually only ran into problems where other changes had been made (such as splitting a large monolithic config resource into smaller files).
ok got it
I'm closing this PR
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-14 21:14:41 |
Closed_By | ⇒ | hardik-codes | |
Labels |
Added:
?
?
|
This is exactly what #23229 is. That PR is not yet merged to 4.0.
If a change has already been made on staging (3.x), it does not need a separate pull request for 4.0. It will eventually merge forward as the backlog clears out.