? ? Pending

User tests: Successful: Unsuccessful:

avatar hardik-codes
hardik-codes
14 Mar 2019

Summary of Changes

Changed the update message (also made it a warning instead of a notice )so that users make backup before updating.

Testing Instructions

Code Inspection

Documentation Changes Required

None

avatar hardik-codes hardik-codes - open - 14 Mar 2019
avatar hardik-codes hardik-codes - change - 14 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2019
Category Administration com_installer com_joomlaupdate Language & Strings
avatar mbabker
mbabker - comment - 14 Mar 2019

This is exactly what #23229 is. That PR is not yet merged to 4.0.

If a change has already been made on staging (3.x), it does not need a separate pull request for 4.0. It will eventually merge forward as the backlog clears out.

avatar hardik-codes
hardik-codes - comment - 14 Mar 2019

Ok then I'll close this

avatar hardik-codes
hardik-codes - comment - 14 Mar 2019

@mbabker just had one question
Since naming convention for files have changed in J4
In J(3.x) we had view.html.phpwhereas in J4 we have HtmlView.php
Will that not make merging difficult?

avatar brianteeman
brianteeman - comment - 14 Mar 2019

That is why there is a backlog. But it's a waste of resources to do things twice

avatar mbabker
mbabker - comment - 14 Mar 2019

Since naming convention for files have changed in J4
In J(3.x) we had view.html.phpwhereas in J4 we have HtmlView.php
Will that not make merging difficult?

Depends on a lot of variables. If files were all moved with git's move command, its history usually does a pretty good job of saying "this file has been moved, so apply this segment of the diff to the new location instead". When things get too far diverged that's when you start running into problems with git not being able to sanely follow your renames. I've redone the folder structure on an application just as large as Joomla and thanks to carefully moving files when I needed to merge changes for the live production system into the in-progress refactoring I usually only ran into problems where other changes had been made (such as splitting a large monolithic config resource into smaller files).

avatar hardik-codes
hardik-codes - comment - 14 Mar 2019

ok got it
I'm closing this PR

avatar hardik-codes hardik-codes - change - 14 Mar 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-03-14 21:14:41
Closed_By hardik-codes
Labels Added: ? ?
avatar hardik-codes hardik-codes - close - 14 Mar 2019

Add a Comment

Login with GitHub to post a comment