[#24174] - [4.0] [WIP] Use namespaced classes everywhere
- Closed
- 15 Mar 2019
- Medium
- Build: 4.0-dev
- Draft PR
- # 24174
- Diff
- C-Lodder:namespace--all
User tests: Successful: Unsuccessful:
Pull Request for Issue #24108
Summary of Changes
I'm aware that there are still instances where the J prefixed class only resides in comment blocks and the use case is still added. My regex stills aren't top notch so I'll leave it up the the powers that be to decide whether or not they're fussed about this. If it's a problem I can close this and anyone willing to improve the regex can take over from me.
- JText
- JPath
- JFile
- JFolder
- JStream
- JFilesystemHelper
- JObject
- JImageFilter
- JImage
- JFeedPerson
- JFeedParser
- JFeedEntry
- JFeed
- JInputFiles
- JInputCli
Testing Instructions
Browse through the frontend/backend and check for any errors
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_checkin com_config com_contact com_content com_contenthistory com_csp com_fields com_installer com_joomlaupdate com_languages |
When the change is only in the docblock does it still need to have the use namespace statement?
No. My regex initially dealt with comment blocks but then only detected classes with a leading backslash. Couldnt figure it out so just stuck with this
| Labels |
Added:
?
|
||
There's still many issues left. Maybe it would be simpler to do this by directory or extension rather than by class.
For classes that are only used as part of a docblock you could remove import statements and use fully qualified names instead. Not sure which is the preferred way. @joomla/maintainers?
For classes only used in inline comments use fully qualified names and no import statement.
For classes that are only used as part of a docblock you could remove import statements and use fully qualified names instead. Not sure which is the preferred way. @joomla/maintainers?
I wonder how that could happen? What is in your docblock is used in your function or not?
My idea is we use imports for everything but whatever the powers may decide :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-15 10:28:29 |
| Closed_By | ⇒ | C-Lodder |
cool stuff