Labels |
Added:
?
|
Status | New | ⇒ | Discussion |
For Preview
, it is quite simple
It is first translated in
https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Toolbar/ToolbarButton.php#L121
as every toolbar button by default
Then it is translated again in
https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/View/Article/HtmlView.php#L197-L200
This one can be solved here by modifying this last one to
$url = PreviewHelper::url($this->item);
$toolbar->preview($url, 'JGLOBAL_PREVIEW')
->bodyHeight(80)
->modalWidth(90);
I could not find a way for Change Status
Started working on this.
@SharkyKZ are you sure that this is being caused by repetition of strings, I can find the repetetion
in the 'preview' thing as @infograf768 said but couldn't find the repetetion in case of Change Status.
Site menus are not translatable.
are you sure that this is being caused by repetition of strings
Yes, it's because Joomla\CMS\Toolbar\Button\DropdownButton::prepareOptions()
calls parent::prepareOptions()
which translates the string and then uses the options to create a new button. But new button expects an untranslated string.
Indeed
$this->getText()
also uses Text::_
ok I get it thanks.
@infograf768 Issue stay open?
remains the Change Status issue to solve, if possible.
Category | ⇒ | com_languages |
Labels |
Added:
J4 Issue
|
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-07 07:28:36 |
Closed_By | ⇒ | brianteeman |
Status | Closed | ⇒ | New |
Closed_Date | 2019-06-07 07:28:36 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Status | New | ⇒ | Discussion |
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-23 20:21:59 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
No Code Attached Yet
Removed: ? |
Closing - not worth keeping it open for this edge case.
It means the string is translated multiple times.