? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
11 Mar 2019

Pull Request for Issue #24155 .

Summary of Changes

use the correct method parameter

Testing Instructions

install an extension (i.e com_patchtester)
uninstall the previous one

Expected result

Extension is uninstalled correctly

Actual result

Error 'Too few arguments' passed to the function 'onExtensionBeforeUninstall' of the new plugin 'extension/finder/finder.php'

avatar alikon alikon - open - 11 Mar 2019
avatar alikon alikon - change - 11 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2019
Category Front End Plugins
avatar SharkyKZ
SharkyKZ - comment - 11 Mar 2019

This isn't right. The plugin should only run after uninstallation. See PR #24163 for alternative.

avatar alikon
alikon - comment - 11 Mar 2019

@SharkyKZ this is at least debatable, so let's ping @Hackwar who surely knows this matter at least better than me ?

avatar SharkyKZ
SharkyKZ - comment - 11 Mar 2019

Test this scenario:

View #__finder_terms_common table. See it has some words for en language.
Try to uninstall en-GB (core) language. The installation will fail because it can't be uninstalled.
View #__finder_terms_common again. The data is now gone.

avatar alikon
alikon - comment - 11 Mar 2019

so this is not a real life scenario, btw, i've no problem on closing this pr in favour of your pr #24163

just want to listen some others feedback....before

avatar alikon
alikon - comment - 14 Mar 2019

closing #24163 as is merged

avatar alikon alikon - close - 14 Mar 2019
avatar alikon alikon - change - 14 Mar 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-03-14 11:32:52
Closed_By alikon
Labels Added: ?

Add a Comment

Login with GitHub to post a comment