Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#24160] - [4.0] added missing class in buttons

J4 Issue NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar bahl24
bahl24
11 Mar 2019

Pull Request for Issue -Required class missing for Cancel button leading to inconsistency from other modals in Joomla.

Summary of Changes

Added class

Testing Instructions

Build vue files in com_media before testing

Expected result

Screenshot from 2019-03-11 21-21-16

Actual result

Screenshot from 2019-03-11 21-23-53

avatar bahl24 bahl24 - open - 11 Mar 2019
avatar bahl24 bahl24 - change - 11 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2019
Category ⇒ Administration com_media NPM Change
avatar SharkyKZ
SharkyKZ - comment - 11 Mar 2019

This is intentional. That's why these buttons have btn-link class. If the change is accepted, then btn-link class should be removed.

avatar bahl24
bahl24 - comment - 11 Mar 2019

@SharkyKZ Ok, but does btn-link offers some additional functionality in addition to style?
Because, I think the buttons should be consistent as it is in other modals across J4, such as
Screenshot from 2019-03-11 22-04-59

avatar SharkyKZ
SharkyKZ - comment - 11 Mar 2019

No, it just makes buttons look like links. I don't know which class should be used. But it should be one or the other, not both at the same time.

avatar Quy
Quy - comment - 19 Mar 2019

Remove btn-link to be consistent with other Cancel buttons.

avatar bahl24 bahl24 - change - 19 Mar 2019
Labels Added: NPM Resource Changed ?
avatar Quy
Quy - comment - 19 Mar 2019

I have tested this item ✅ successfully on 57ade00

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24160.

avatar Quy Quy - test_item - 19 Mar 2019 - Tested successfully
avatar bahl24
bahl24 - comment - 9 Apr 2019

@SharkyKZ Kindly test

avatar SharkyKZ
SharkyKZ - comment - 9 Apr 2019

I have tested this item ✅ successfully on 57ade00

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24160.

avatar SharkyKZ
SharkyKZ - comment - 9 Apr 2019

I have tested this item ✅ successfully on 57ade00

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24160.

avatar SharkyKZ SharkyKZ - test_item - 9 Apr 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Apr 2019
Title
…
[4.0]added missing class in buttons
[4.0] added missing class in buttons
avatar franz-wohlkoenig franz-wohlkoenig - edited - 9 Apr 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Apr 2019
Status Pending ⇒ Ready to Commit
avatar bahl24 bahl24 - change - 9 Apr 2019
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Apr 2019

All fine. Sometimes its not synchronized between Tracker and Github but i don't remember what happens 2 Hours ago :-)

avatar SharkyKZ
SharkyKZ - comment - 10 Apr 2019

@franz-wohlkoenig Thanks. But RTC label is still missing on Github.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Apr 2019

Its shown on Issue Tracker (green Background too) and Github on right Side top.

avatar brianteeman
brianteeman - comment - 10 Apr 2019

image

image

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Administration com_media NPM Change ⇒ Administration com_media
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2019
Category Administration com_media ⇒ Administration com_media NPM Change
avatar wilsonge wilsonge - change - 12 Apr 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-04-12 13:19:35
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 12 Apr 2019
avatar wilsonge wilsonge - merge - 12 Apr 2019
avatar wilsonge
wilsonge - comment - 12 Apr 2019

Thanks!

Add a Comment

Login with GitHub to post a comment