? ? Pending

User tests: Successful: Unsuccessful:

avatar hardik-codes
hardik-codes
9 Mar 2019

Pull Request for Issue #22544 .

Summary of Changes

Addedtitle attribute in layouts/joomla/toolbar/basic.php
Also added audible notifications to help button to satisfy the accessibility rules

Testing Instructions

Go to Content => Articles
Hover on the Help button.

Expected result

22544
Also audible notifications for screen readers

Actual result

No visible and audible notification

Documentation Changes Required

None

avatar hardik-codes hardik-codes - open - 9 Mar 2019
avatar hardik-codes hardik-codes - change - 9 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Mar 2019
Category Administration Language & Strings Layout
avatar C-Lodder
C-Lodder - comment - 9 Mar 2019

It's a shame screen readers don't automatically detect the target attribute

avatar TobsBobs
TobsBobs - comment - 9 Mar 2019

I have tested this item successfully on f0684b0


Unbenannt

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24138.

avatar TobsBobs TobsBobs - test_item - 9 Mar 2019 - Tested successfully
avatar hardik-codes hardik-codes - change - 9 Mar 2019
Labels Added: ? ?
avatar hardik-codes
hardik-codes - comment - 9 Mar 2019

Now have a look @brianteeman

avatar zwiastunsw
zwiastunsw - comment - 9 Mar 2019

Opening the help screen in a new window is visible to sighted users. The change of context is not surprising in this case. In particular, closing the help window will return to the place where the window has been opened.
However, it is advisable to notify blind users about opening in new window. For this purpose it is enough to use text visible only for screen readers.
Additionally: Simultaneous use of the title and text attribute only for screen readers causes screen readers to announce the same message twice (except for JAWS, if title attribute reading is not enabled).

In my opinion: use only the title attribute or text visible only for screen readers. Personally, I am in favour of text that is only visible to screen readers.

avatar brianteeman
brianteeman - comment - 9 Mar 2019

The WCAG guidelines are clear that all users should be informed if a link opens in a new window
https://www.w3.org/TR/WCAG20-TECHS/G201.html

avatar astridx
astridx - comment - 9 Mar 2019

I think we can not do it like this, because /libraries/src/Toolbar/Button/DropdownButton.php uses this layout too and because of this some other buttons have this tooltip, too. (/libraries/src/Toolbar/Button/DropdownButton.php inherited it from /libraries/src/Toolbar/Button/AbstractGroupButton.php)
For example the button Change Status in /administrator/index.php?option=com_content&view=articles. See picture.

Bildschirmfoto von 2019-03-09 16-30-57

avatar zwiastunsw
zwiastunsw - comment - 9 Mar 2019

I do not want to discuss unnecessarily, but:
2. G201 is an advisory technique (recommended, but not obligatory).
2. Success Criteria 3.2.1 and 3.2.2 (Level A) relate to an automatic change of context when the light is focused or after data has been entered. This is not the case here. Here we have a situation which is the Success criterion 3.2.5 (Level AAA).
3. Since we have a change of context here which may cause confusion especially among blind people this PR is needed.
4. My intention was to advise to use one way to notify the user (title or text attribute for screen readers only). Using both ways causes unnecessary information noise. This is also a violation of accessibility.

avatar brianteeman
brianteeman - comment - 9 Mar 2019

I have tested this item ? unsuccessfully on 805e2a4

the basic button is used for more than the help buttons. Possible option would be to have a new layout for the help button


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24138.

avatar brianteeman brianteeman - test_item - 9 Mar 2019 - Tested unsuccessfully
avatar hardik-codes
hardik-codes - comment - 9 Mar 2019

@brianteeman is there any layout for the help button already ?

avatar brianteeman
brianteeman - comment - 9 Mar 2019

No, that's why I said new

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Apr 2019
Category Administration Language & Strings Layout Administration Layout
avatar Quy Quy - change - 18 Jun 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-06-18 04:24:29
Closed_By Quy
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2019
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 18 Jun 2019
avatar joomla-cms-bot
joomla-cms-bot - comment - 18 Jun 2019

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24138

avatar Quy
Quy - comment - 18 Jun 2019

Closing as not the proper fix.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24138.

avatar joomla-cms-bot joomla-cms-bot - change - 18 Jun 2019
Category Administration Layout Administration Language & Strings Layout

Add a Comment

Login with GitHub to post a comment