? Pending

User tests: Successful: Unsuccessful:

avatar 810
810
8 Mar 2019

Pull Request for Issue # .

Summary of Changes

Wrong namespace, and not needed.

Testing Instructions

Code check

Expected result

No warning

Actual result

undefined class router

Documentation Changes Required

avatar 810 810 - open - 8 Mar 2019
avatar 810 810 - change - 8 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Mar 2019
Category Libraries
avatar wilsonge
wilsonge - comment - 8 Mar 2019

These are the right classes and they are needed. The class extends router and the route class is used on line 65

avatar wilsonge
wilsonge - comment - 8 Mar 2019

They are defined in the joomla/router package https://github.com/joomla/joomla-cms/blob/4.0-dev/composer.lock#L1323-L1371 - my best assumption is you didn't refresh you're composer dependencies when you pulled down the api code in the 4.0 branch

avatar 810
810 - comment - 8 Mar 2019

yes, thnx I though it was the use Joomla\CMS\Router\Router; use Joomla\CMS\Router\Route;

composer update fixed the issue.

avatar 810 810 - change - 8 Mar 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-03-08 23:26:23
Closed_By 810
Labels Added: ?
avatar 810 810 - close - 8 Mar 2019

Add a Comment

Login with GitHub to post a comment