? J4 Issue ?
avatar hitaly
hitaly
8 Mar 2019

Steps to reproduce the issue

add the main menu module to position MENU .
add the search module to position SEARCH .
test it on mobile :
the search show just after click on the colaps menu button .screen shot 2019-03-08 at 14 38 03

Expected result

extract the search position from the navbar div

Actual result

System information (as much as possible)

joomla 4 alpha 6

Additional comments

avatar hitaly hitaly - open - 8 Mar 2019
avatar joomla-cms-bot joomla-cms-bot - labeled - 8 Mar 2019
avatar hitaly hitaly - change - 8 Mar 2019
The description was changed
avatar hitaly hitaly - edited - 8 Mar 2019
avatar ghost
ghost - comment - 8 Mar 2019

Please add "[4.0]" at Start of Title.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Mar 2019
Priority Critical Medium
avatar ghost
ghost - comment - 8 Mar 2019

According to https://docs.joomla.org/Bug_and_Issue_Tracker_Priority changed Priority from "Crticial" to "Medium".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Mar 2019

According to https://docs.joomla.org/Bug_and_Issue_Tracker_Priority changed Priority from "Crticial" to "Medium".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.

avatar Quy Quy - change - 8 Mar 2019
Title
extract the search position from the menu position .
[4.0] extract the search position from the menu position .
avatar joomla-cms-bot joomla-cms-bot - edited - 8 Mar 2019
avatar brianteeman
brianteeman - comment - 9 Mar 2019

Reading the code that is the intended behaviour. I assume @ciar4n can explain the reasoning

avatar ciar4n
ciar4n - comment - 9 Mar 2019

I can't remember off hand if this was in @C-Lodder original template PR or something I changed after. I assume the reasoning was for a less cluttered small screen display. I'm easy about it so feel free to change if you deem this an issue.

Is this even going to be the J4 template? I'm hearing mixed reports.

image

avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Mar 2019
Status New Discussion
avatar hitaly
hitaly - comment - 10 Mar 2019

i see the issue on alpha 7 too .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.

avatar ghost
ghost - comment - 22 Mar 2019

@hitaly thats expected if none is working on it.

avatar franz-wohlkoenig franz-wohlkoenig - change - 22 Mar 2019
Category Templates (site)
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar Scrabble96
Scrabble96 - comment - 6 Sep 2019

Why is this expected behaviour? Why hide the search bar in small-screen view, anyway?

I cannot believe that tapping what everyone would believe to be a tappable menu - i.e. the three lines that countless websites use to indicate the presence of a mobile-friendly menu - should display an otherwise hidden search bar.

If I viewed a website with this template I would be very surprised not to find a menu under the three lines.

The main menu in Cassiopeia's default position of sidebar-right disappears completely on a mobile phone if there's any content on the page:

Screenshot_20190906-175610_Chrome-small

The main menu is down below here somewhere in the sidebar that has dropped below the component area.

avatar ciar4n
ciar4n - comment - 6 Sep 2019

Why is this expected behaviour? Why hide the search bar in small-screen view, anyway?

This wasn't done with any serious consideration or reasoning. I don't think anyone would argue against changing it.

avatar Scrabble96
Scrabble96 - comment - 7 Sep 2019

I propose the following change to Cassiopeia index.php and some extra CSS for the search div:

Index.php - remove lines 103 to 115 inclusive:

<?php if ($this->countModules('menu') || $this->countModules('search')) : ?>
<button class="navbar-toggler navbar-toggler-right" type="button" aria-hidden="true" data-toggle="collapse" data-target="#navbar" aria-controls="navbar" aria-expanded="false" aria-label="<?php echo Text::_('TPL_CASSIOPEIA_TOGGLE'); ?>">
<span class="fa fa-bars"></span>
</button>
<div class="collapse navbar-collapse" id="navbar">
<jdoc:include type="modules" name="menu" style="none" />
<?php if ($this->countModules('search')) : ?>
<div class="form-inline">
<jdoc:include type="modules" name="search" style="none" />
</div>
<?php endif; ?>
</div>
<?php endif; ?>

Replace with:

<?php if ($this->countModules('search')) : ?>
<div id="search" class="form-inline">
<jdoc:include type="modules" name="search" style="none"/>
</div>
<?php endif; ?>

Add the following css (somewhere):

#search { margin-top: 10px; }
@media (min-width: 992px) { #search { margin-top: 0; } }

I'm also not sure what would happen if someone wanted to put an actual menu behind the burger bar.

avatar mbabker
mbabker - comment - 7 Sep 2019

In all fairness here, my company has done a few websites where clicking a "hamburger icon" on mobile or tablet devices shows both the main menu and a search bar (usually this also involves an off screen menu coming into view from the side instead of the Bootstrap navbar behavior). So while it might not be the normal thing for many people, it is a practice that is used and can work well. All that to say I don't see an issue with the current behavior myself but we all know what they say about opinions.

avatar Scrabble96
Scrabble96 - comment - 7 Sep 2019

In all fairness here, my company has done a few websites where clicking a "hamburger icon" on mobile or tablet devices shows both the main menu and a search bar.

At the moment, it only shows the search bar.

avatar mbabker
mbabker - comment - 7 Sep 2019

Then I’d say there’s a bit of a logic bug. Either the main menu should be in the header area (as most would expect) which doesn’t make things look “broken” with the hamburger menu only toggling search or there shouldn’t be a menu spot in the header and therefore no need for a hamburger.

At a minimum it sounds like the template needs conditional logic as to whether the hamburger should even render based on whether some module uses the menu position.

avatar Scrabble96
Scrabble96 - comment - 8 Sep 2019

Then I’d say there’s a bit of a logic bug. Either the main menu should be in the header area (as most would expect) which doesn’t make things look “broken” with the hamburger menu only toggling search or there shouldn’t be a menu spot in the header and therefore no need for a hamburger.

I have to agree with you.

avatar jwaisner jwaisner - change - 24 Mar 2020
Status Discussion Information Required
avatar jwaisner
jwaisner - comment - 24 Mar 2020

@hitaly Is this still an issue in the latest J4 build?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.

avatar brianteeman
brianteeman - comment - 24 Mar 2020

@jwaisner nothing has been changed which is why this is still open

avatar jwaisner jwaisner - change - 24 Mar 2020
Priority Medium Low
Status Information Required Confirmed
Build alpha 6 4.0-dev
avatar hitaly
hitaly - comment - 10 Jun 2020

@hitaly Is this still an issue in the latest J4 build?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.

@jwaisner YES YES ...
i tryed it now on j4 beta1 and the issue still there .

avatar hitaly
hitaly - comment - 26 Sep 2020

@jwaisner
i dont know why you turned the Priority to low ?!
and why this bug still there in alpha 4 ?!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.
avatar hitaly
hitaly - comment - 26 Sep 2020

i mean why this bug still there in beta 4 ?!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.

avatar drmenzelit
drmenzelit - comment - 29 Sep 2020

That has been solved in Cassiopeia repository:
joomla/cassiopeia#89

avatar Scrabble96
Scrabble96 - comment - 29 Sep 2020

That has been solved in Cassiopeia repository:
joomla/cassiopeia#89

Well, I never knew that repository was there. How is it different from the joomla-cms repository, which has Cassiopeia files in its code?

avatar C-Lodder
C-Lodder - comment - 29 Sep 2020

@Scrabble96 That repo is dedicated to Cassiopeia fixes and improvements. It will eventually be merged back into this repo.

avatar drmenzelit
drmenzelit - comment - 29 Sep 2020

There is a working group for Cassiopeia improvement. I thought @chmst told that already.
We are preparing a PR for the cms repo.

avatar Scrabble96
Scrabble96 - comment - 29 Sep 2020

There is a working group for Cassiopeia improvement. I thought @chmst told that already.
We are preparing a PR for the cms repo.

@chmst mentioned the working group to me but as I've never been involved with one I had no idea what it entails. I know a bit more, now.

avatar drmenzelit
drmenzelit - comment - 29 Sep 2020

If you are in glip, you can join the Cassiopeia public channel

avatar Quy Quy - change - 29 Sep 2020
Labels Added: ?
avatar Quy Quy - labeled - 29 Sep 2020
avatar hitaly
hitaly - comment - 1 Oct 2020

just now i download beta 4 and test it ... the bug still there and not fixed .
steps :
1- add the menu module to menu position .
2- add the search module to search position .
3- on pc click ctrl with + to zoom in the screen until see the colaps menu icon and the search will hide .
4- click the colaps menu icon , you will see the search under the menu .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.
avatar drmenzelit
drmenzelit - comment - 2 Oct 2020

@hitaly this has been solved in a special Cassiopeia repository. We are preparing a PR for the core.

avatar hitaly
hitaly - comment - 4 Oct 2020

@drmenzelit fantastic
very good news .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24129.

avatar brianteeman
brianteeman - comment - 14 Nov 2020

This should be closed now

avatar Quy Quy - change - 14 Nov 2020
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2020-11-14 17:24:00
Closed_By Quy
avatar Quy Quy - close - 14 Nov 2020

Add a Comment

Login with GitHub to post a comment