? ? Success

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
7 Mar 2019

Summary of Changes

This PR loads the fancy-select layout for some multiple lists instead of the default layout.

Testing Instructions

Check views with multiple select fields (contact, some content modules, ...)

Expected result

Fancy-select layout

Actual result

Defualt list layout

avatar bembelimen bembelimen - open - 7 Mar 2019
avatar bembelimen bembelimen - change - 7 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2019
Category Administration com_contact Modules Front End
avatar wilsonge
wilsonge - comment - 7 Mar 2019

Is there any reason for this other than consistent styling? Because that was the whole reason we ended up with everything being a chosen element. So I think where we can use the browser implementation we should.

avatar bembelimen
bembelimen - comment - 7 Mar 2019

For me the main reason is, that "normal people" don't know to multi-select with ctrl+mouse (+ definitely the layout)
For normal selects we should use the browser default (+ css) but for multiple select, the browser defaults are still unusable (imho)

avatar brianteeman
brianteeman - comment - 7 Mar 2019

Really?

For me we should only be using fancy-select when we need the extra functionality such as the ability to search a very long list. Which at a quick glance is probably true for most of these

avatar bembelimen bembelimen - change - 7 Mar 2019
Labels Added: ?
avatar Bodge-IT
Bodge-IT - comment - 20 Mar 2019

I have tested this item successfully on f9d654a

Tested:
Components:
Contacts (2 elements found)
Modules:
Articles Latest
Articles Most Read
Articles: Newsflash
Banners
Tags: Popular

If I've missed any, please provide list.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24122.
avatar Bodge-IT Bodge-IT - test_item - 20 Mar 2019 - Tested successfully
avatar flyingwombats
flyingwombats - comment - 20 Mar 2019

I have tested this item successfully on f9d654a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24122.

avatar flyingwombats flyingwombats - test_item - 20 Mar 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Mar 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Mar 2019

Status "Ready To Commit".

avatar bembelimen bembelimen - change - 22 Mar 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2019
Category Administration com_contact Modules Front End Administration com_contact Modules Front End NPM Change
avatar bembelimen bembelimen - change - 22 Mar 2019
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 22 Mar 2019
Category Administration com_contact Modules Front End NPM Change Administration com_contact Modules Front End
avatar HLeithner
HLeithner - comment - 23 Mar 2019

Can we get another test because choices has been updated. Then we can merge it, to get tinymce merged.

avatar bembelimen
bembelimen - comment - 23 Mar 2019

Can we get another test because choices has been updated. Then we can merge it, to get tinymce merged.

No Choices update here, I reverted it, I did it on the wrong branch...

avatar wilsonge
wilsonge - comment - 16 Apr 2019

I'm going to close this. I disagree with choices becoming the new chosen by using it everywhere. We use it where we need the full functionality (basically tags or searching lists of items)

avatar wilsonge wilsonge - change - 16 Apr 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-04-16 15:27:35
Closed_By wilsonge
Labels Removed: J4 Issue
avatar wilsonge wilsonge - close - 16 Apr 2019

Add a Comment

Login with GitHub to post a comment