User tests: Successful: Unsuccessful:
Added aria-current
to modules/mod_breadcrumbs/tmpl/default.php
Apply the patch and check the generated code of breadcrumbs module
None
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Front End |
@Anu1601CS apply patch. check generated code of breadcrumbs module.
I have tested this item
I have tested this item successfully. As much as I see, a possible vaue could be "page", but should be the same effect for assisitive technologies.
@brianteeman We know how to test. Instructions only for new students who want to test :)
@zwiastunsw if you prefer the aria-current="page", @hardik-codes can change it.
Comment by LÉONIE WATSONJANUARY 26TH 2017, 8:44AM
I don’t think there are hard rules for which token to use. I’ve used “location” in the breadcrumb example, but “page” would also be ok.
I chose to use “location” because that’s the purpose of a breadcrumb trail, and using “page” wouldn’t convey that as well as “page”. But it’s entirely subjective!
I know the opinion of L. Watson and I fully agree with her. The value "true" is also correct here, although it is better to use a "page" or "location".
Much more important to me is whether the current item is a link.
If it is not a link, the aria-current attribute improves accessibility in an unnoticeable way. The screen reader user will only hear this information if he listens to the page. If the last track element is not a link, it does not gain focus during tabulation, which means that the screen reader user will not hear this information. Therefore, if it is not a link, the aria-current attribute is optional (see: WAI-ARIA Authoring Practices 1.1 - Breadcrumb.
@hardik-codes Please provide testing instructions and image if possible.
@Anu1601CS I've updated the testing instructions as per @brianteeman guidelines
@zwiastunsw as I have commented before, the last link in a breadcrumb never is a link but a text. Always.
you wrote
Let's consider whether this item should have an aria-current attribute?
In my opinion yes. Regardless of whether it will be a link or not. Because the user of the screen reader may receive additional important information. It will hear information that the visually impaired user can read from the screen. This is good for accessibility.
So now we need a decision: Do we use the attribute in joomla or not?
Here is an example of how a screen reader announces a breadcrumb when the last item is a link:
Breadcrumb navigation landmark
list with 4 items
Home link
Products link
Computers link
Laptops link current page
If the last item is not a link, the screen reader skips it during tabulation. The cursor moves to the next item on the page. The user hears only:
Breadcrumb navigation landmark
list with 4 items
Home link
Products link
Computers link
Note: The screen reader announces that there are 4 items, but communicates only three items.
In addition: When the next interactive element on the page is a link, the screen reader will read it as if it belonged to the breadcrumb. A blind user may think that this is another element of the breadcrumb.
That is why I believe that this should be a link. But this does not mean that it is just the right solution. It is a question of preference. I do not know of studies that would show which solution blind people prefer.
If I had to decide, the last element would be made by a link.
Having a link to the same page makes no sense
Unlikely that the next link would be announced as being part of the breadcrumb list because the links should be enclosed in a different region
Having a link to the same page makes no sense
You have the right to think this way. But that's just your opinion. In the navigation menu we have links to the current page. We even have special CSS classes for them - current, active. Doesn't it also make sense?
I would like to emphasise once again: I do not think that my opinion is merely the right one. We have different patterns on the web.
The W3C in the WAI-ARIA Practices document presents a breadcrumb design pattern in which the last element is a link. Doesn't make sense?
Scott O'Hara has a link in its solution as the last element. Doesn't make sense? He argues for its solution:
Some other breadcrumb patterns remove the
<a>
element, or at least thehref
from the link. These examples retain thea href
for current link, as without it, people using a screen reader and navigating by links, or via focusable content with thetab
key would not come across the currently active link.
Still regarding the value of the aria-current
attribute.
true
is set by default when not specified.page
indicates the current page in the link setlocation
indicates the current highlighted image in the chart.The screen reader announces accordingly: "current" || "current page" || "location".
Definitely, it is best to use the value page
.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Labels |
Added:
?
|
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-15 13:20:20 |
Closed_By | ⇒ | wilsonge |
Changed to the value of page
and merged
@hardik-codes Please provide testing instructions and image if possible.