? ? Pending

User tests: Successful: Unsuccessful:

avatar hardik-codes
hardik-codes
7 Mar 2019

Summary of Changes

Added aria-current to modules/mod_breadcrumbs/tmpl/default.php

Testing Instructions

Apply the patch and check the generated code of breadcrumbs module

Documentation Changes Required

None

avatar hardik-codes hardik-codes - open - 7 Mar 2019
avatar hardik-codes hardik-codes - change - 7 Mar 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2019
Category Modules Front End
avatar Anu1601CS
Anu1601CS - comment - 7 Mar 2019

@hardik-codes Please provide testing instructions and image if possible.

avatar brianteeman
brianteeman - comment - 7 Mar 2019

@Anu1601CS apply patch. check generated code of breadcrumbs module.

avatar chmst chmst - test_item - 7 Mar 2019 - Tested successfully
avatar chmst
chmst - comment - 7 Mar 2019

I have tested this item successfully on 34d63f3

I have tested this item successfully. As much as I see, a possible vaue could be "page", but should be the same effect for assisitive technologies.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24113.

avatar chmst chmst - test_item - 7 Mar 2019 - Tested successfully
avatar Anu1601CS
Anu1601CS - comment - 7 Mar 2019

@brianteeman We know how to test. Instructions only for new students who want to test :)

avatar chmst
chmst - comment - 7 Mar 2019

@zwiastunsw if you prefer the aria-current="page", @hardik-codes can change it.

avatar brianteeman
brianteeman - comment - 7 Mar 2019

Comment by LÉONIE WATSONJANUARY 26TH 2017, 8:44AM

I don’t think there are hard rules for which token to use. I’ve used “location” in the breadcrumb example, but “page” would also be ok.
I chose to use “location” because that’s the purpose of a breadcrumb trail, and using “page” wouldn’t convey that as well as “page”. But it’s entirely subjective!

https://tink.uk/using-the-aria-current-attribute/

avatar zwiastunsw
zwiastunsw - comment - 7 Mar 2019

I know the opinion of L. Watson and I fully agree with her. The value "true" is also correct here, although it is better to use a "page" or "location".
Much more important to me is whether the current item is a link.
If it is not a link, the aria-current attribute improves accessibility in an unnoticeable way. The screen reader user will only hear this information if he listens to the page. If the last track element is not a link, it does not gain focus during tabulation, which means that the screen reader user will not hear this information. Therefore, if it is not a link, the aria-current attribute is optional (see: WAI-ARIA Authoring Practices 1.1 - Breadcrumb.

avatar hardik-codes hardik-codes - change - 8 Mar 2019
The description was changed
avatar hardik-codes hardik-codes - edited - 8 Mar 2019
avatar hardik-codes
hardik-codes - comment - 8 Mar 2019

@hardik-codes Please provide testing instructions and image if possible.

@Anu1601CS I've updated the testing instructions as per @brianteeman guidelines

avatar chmst
chmst - comment - 8 Mar 2019

@zwiastunsw as I have commented before, the last link in a breadcrumb never is a link but a text. Always.

Here joomla/accessibility#51

you wrote

Let's consider whether this item should have an aria-current attribute?

In my opinion yes. Regardless of whether it will be a link or not. Because the user of the screen reader may receive additional important information. It will hear information that the visually impaired user can read from the screen. This is good for accessibility.

So now we need a decision: Do we use the attribute in joomla or not?

avatar zwiastunsw
zwiastunsw - comment - 8 Mar 2019

Here is an example of how a screen reader announces a breadcrumb when the last item is a link:

Breadcrumb navigation landmark
list with 4 items
Home link
Products link
Computers link
Laptops link current page

If the last item is not a link, the screen reader skips it during tabulation. The cursor moves to the next item on the page. The user hears only:

Breadcrumb navigation landmark
list with 4 items
Home link
Products link
Computers link

Note: The screen reader announces that there are 4 items, but communicates only three items.
In addition: When the next interactive element on the page is a link, the screen reader will read it as if it belonged to the breadcrumb. A blind user may think that this is another element of the breadcrumb.

That is why I believe that this should be a link. But this does not mean that it is just the right solution. It is a question of preference. I do not know of studies that would show which solution blind people prefer.

If I had to decide, the last element would be made by a link.

avatar brianteeman
brianteeman - comment - 8 Mar 2019

Having a link to the same page makes no sense

Unlikely that the next link would be announced as being part of the breadcrumb list because the links should be enclosed in a different region

avatar zwiastunsw
zwiastunsw - comment - 8 Mar 2019

Having a link to the same page makes no sense

You have the right to think this way. But that's just your opinion. In the navigation menu we have links to the current page. We even have special CSS classes for them - current, active. Doesn't it also make sense?

I would like to emphasise once again: I do not think that my opinion is merely the right one. We have different patterns on the web.

The W3C in the WAI-ARIA Practices document presents a breadcrumb design pattern in which the last element is a link. Doesn't make sense?
Scott O'Hara has a link in its solution as the last element. Doesn't make sense? He argues for its solution:

Some other breadcrumb patterns remove the <a> element, or at least the href from the link. These examples retain the a href for current link, as without it, people using a screen reader and navigating by links, or via focusable content with the tab key would not come across the currently active link.

avatar zwiastunsw
zwiastunsw - comment - 8 Mar 2019

Still regarding the value of the aria-current attribute.

  • the value true is set by default when not specified.
  • the value page indicates the current page in the link set
  • the value location indicates the current highlighted image in the chart.

The screen reader announces accordingly: "current" || "current page" || "location".

Definitely, it is best to use the value page.

See: WAI-ARIA 1.2 aria-current (state).

avatar flyingwombats flyingwombats - test_item - 8 Mar 2019 - Tested successfully
avatar flyingwombats
flyingwombats - comment - 8 Mar 2019

I have tested this item successfully on 34d63f3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24113.

avatar franz-wohlkoenig franz-wohlkoenig - change - 8 Mar 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Mar 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - change - 15 Mar 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 15 Mar 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 15 Mar 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-03-15 13:20:20
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Mar 2019
avatar wilsonge wilsonge - merge - 15 Mar 2019
avatar wilsonge
wilsonge - comment - 15 Mar 2019

Changed to the value of page and merged

avatar zwiastunsw
zwiastunsw - comment - 16 Mar 2019

thanks @wilsonge

Add a Comment

Login with GitHub to post a comment