? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Mar 2019

Removes the sidebar for templates and styles. They are not replaced as they are accessed directly from the system dashboard instead of the components menu

avatar brianteeman brianteeman - open - 4 Mar 2019
avatar brianteeman brianteeman - change - 4 Mar 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2019
Category ⇒ Administration com_templates
avatar brianteeman brianteeman - change - 5 Mar 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 5 Mar 2019

Just taking off the sidebar is not so nice.
If one edits a style or modifies a template file, then it is necessary to display again the System Cpanel to go to the other template manager.
New Toolbar buttons may help.

avatar brianteeman
brianteeman - comment - 5 Mar 2019

Exactly as menitoned by @wilsonge in another PR and as I replied - that is beyond the scope of this pr and is perhaps something the template team have resolved already as the system dashboard is there idea

avatar Bodge-IT Bodge-IT - test_item - 6 Mar 2019 - Tested unsuccessfully
avatar Bodge-IT
Bodge-IT - comment - 6 Mar 2019

I have tested this item ? unsuccessfully on 4f60f73

Cleared cache after patch applied.
Checked all System & Component links items and found sidebar in:

  • Clear Cache
  • Clear Expired Cache
  • Glocal
  • Warnings
  • Discover
  • Install Language
  • Extensions
  • Update Sources
  • Text Filters
  • Settings (Duplicates Global)
    Components:
  • Smart Search
  • Contacts
    • Categories

Templates sidebar was removed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.

avatar Quy
Quy - comment - 6 Mar 2019

@Bodge-IT This PR is for Templates sidebar.
24092

avatar brianteeman
brianteeman - comment - 6 Mar 2019

@Bodge-IT As the pr says - this only removes the sidebar for templates and styles - not anything else. They all have their own prs

avatar Bodge-IT
Bodge-IT - comment - 7 Mar 2019

OK I missed that. I'll retest.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.
avatar flyingwombats flyingwombats - test_item - 7 Mar 2019 - Tested successfully
avatar flyingwombats
flyingwombats - comment - 7 Mar 2019

I have tested this item ✅ successfully on 4f60f73

Tested and removes the sidebar in style and template in both site and administrator


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.

avatar Bodge-IT Bodge-IT - test_item - 7 Mar 2019 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 7 Mar 2019

I have tested this item ✅ successfully on 4f60f73

Sidebar removed for Styles and Templates on both Site and Admin


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24092.
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Mar 2019
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Mar 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - change - 21 Mar 2019
Labels Added: ?
avatar wilsonge
wilsonge - comment - 21 Mar 2019

Thanks!

avatar wilsonge wilsonge - close - 21 Mar 2019
avatar wilsonge wilsonge - merge - 21 Mar 2019
avatar wilsonge wilsonge - change - 21 Mar 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-03-21 13:07:40
Closed_By ⇒ wilsonge
avatar brianteeman
brianteeman - comment - 21 Mar 2019

thanks

Add a Comment

Login with GitHub to post a comment