[#24086] - [com_actionlogs] - fix checkLoggable for com_checkin
- Fixed in Code Base
- 11 Mar 2019
- Medium
- Build: staging
- # 24086
- Diff
- alikon:patch-81
User tests: Successful: Unsuccessful:
Pull Request for Issue #24071 .
Summary of Changes
fix checkLoggable for com_checkin
Testing Instructions
Uncheck the form com_actionlogs Options com_checkin from Events To Log
Expected result
check-in actions are not logged
Actual result
check-in actions are logged
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24086.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24086.
Why is only com_checkin valid for checking logging?
I think, because after onAfterCheckin event.
Can only com_checking trigger this event or checkin items? Or is this only for the global checkin?
I "think" the real problem to resolve is that we only want to record in the action logs when someone actively does a checkin - either from the component or by pressing the checkin button in the toolbar.
However what current actionlog does is record every time something is checked in - and that will happen automatically every time you save an item etc and we don't want to log that.
with #23526 every table can trigger the onAfterCheckin event see https://github.com/joomla/joomla-cms/blob/staging/libraries/src/Table/Table.php#L1149 this pr fix that till, now everytime a checkin event occurs it is always logged unrespectful for what you have setted on the Events To Log
| Labels |
Added:
?
|
||
So this should go into 3.9.4?
from my personal POV yes, cause is a fix for a bug, but the final decision it's up to the mantainers ...
oops ... are you
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-11 10:41:25 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
I have tested this item✅ successfully on 8e68899
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24086.