[#24083] - [4.0] small screen toolbar toggle fix
- Closed
- 18 Jul 2019
- Medium
- Build: 4.0-dev
- # 24083
- Diff
- hardik-codes:Fix#23815
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23815 .
Summary of Changes
Changes in administrator/templates/atum/index.php
Testing Instructions
Open the articles and reduce the browser viewport size
Expected result
Toolbar displayed/hidden when toggle button is clicked
Actual result
The toolbar toggle button does nothing
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Members please test this PR
Sorry, I am not sure what we should see. Are you talking about the Toggle menu button when in
/administrator/index.php?option=com_fields&context=com_content.article
The toggle seems to work before the patch is applied even when the page is made small
Could you show an image of it in the broken and patched state so I can work out if I am looking at the right thing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24083.
@flyingwombats
Resize your browser window and you will find a toolbar button
Earlier this button was not toggleable but after the patch it is toggleable.
Tested this and the toggle now works but no styling and no cursor change on hover, were these excpected?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24083.
I have tested this item
Toggle button toggles after patch.
Note: No cursor indication of "button"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24083.
Note this fails almost every measure of accessibility
franz-wohlkoenig
- | Title |
|
||||||
| Closed_Date | 2019-07-18 17:26:36 | ⇒ | 2019-07-18 17:26:37 |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-18 17:26:36 |
| Closed_By | ⇒ | Quy |
This is no longer an issue with the new backend template. Please test PR #25570.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24083.
@ciar4n please have a look and suggest me changes if any.