J4 Issue ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Feb 2019

Now that we have the System menu and its grouped links there is no need for the sidebar within com_cache and com_checkin. It was fake that they were connected into one in the first place.

Screenshots

image

image

avatar brianteeman brianteeman - open - 26 Feb 2019
avatar brianteeman brianteeman - change - 26 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2019
Category Administration com_cache com_checkin Language & Strings
avatar brianteeman brianteeman - change - 27 Feb 2019
Labels Added: ? ?
avatar Bodge-IT
Bodge-IT - comment - 9 Mar 2019

Quick check, while this does as it says and removes the sidebar, it also breaks the language string for the Table Options button, is that a pass or Fail?
screen shot 2019-03-09 at 08 07 40


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24030.

avatar brianteeman
brianteeman - comment - 9 Mar 2019

Thanks for testing Gary but I can't see how any of the changes here would cause that

avatar Bodge-IT
Bodge-IT - comment - 10 Mar 2019

IKR but reverting patch brings it back. I noticed in #16909, mention of redundant language strings, could that be related?
Happy to pass this as test objective was fulfilled just wanted to highlight break.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24030.

avatar Bodge-IT
Bodge-IT - comment - 10 Mar 2019

I have tested this item successfully on daa473c

Sidebar removed in System/Clear Cache, system/Clear Expired Cache, system/Global Checkin

Note: Language string on Table Options button breaks on application of patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24030.
avatar Bodge-IT Bodge-IT - test_item - 10 Mar 2019 - Tested successfully
avatar fabpacheco
fabpacheco - comment - 31 Mar 2019

I have tested this item successfully on e8b2cf9

It works and there is no problem with the language string for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24030.

avatar fabpacheco fabpacheco - test_item - 31 Mar 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Mar 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Mar 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - change - 9 Apr 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-04-09 15:23:01
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Apr 2019
avatar wilsonge wilsonge - merge - 9 Apr 2019
avatar wilsonge
wilsonge - comment - 9 Apr 2019

Thanks!

avatar brianteeman
brianteeman - comment - 9 Apr 2019

Thanks

Add a Comment

Login with GitHub to post a comment