[#24028] - [4.0] Featured view: corrected rss feed func
- Fixed in Code Base
- 18 Aug 2019
- Medium
- Build: 4.0-dev
- # 24028
- Diff
- bahl24:rss_feed
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue - Syndication Module in frontend not working .
Testing Instructions
Click on any RSS button to get an error
Expected result
XML version
Actual result
Error
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-27 12:58:16 |
| Closed_By | ⇒ | bahl24 |
@infograf768 I have made the changes you suggested and escape function is the same as return htmlspecialchars($var, ENT_QUOTES, $this->_charset); so it doesn't matter and seems correct to me.
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-02-27 12:58:16 | ⇒ | |
| Closed_By | bahl24 | ⇒ |
| Status | New | ⇒ | Pending |
@infograf768 Kindly test this
Restarted drone
@infograf768 I think there is some issue in 4.0 branch itself as build of many PR is failing.
@infograf768 @alikon Restarted as drone is back on track,kindly test
@infograf768 Kindly test this, I think the changes have been finalised
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24028.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24028.
@infograf768 can you please retest?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24028.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-18 23:31:03 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
This is only broken for the featured view with error
Call to undefined method Joomla\Component\Content\Site\View\Featured\FeedView::escape()Due to the fact that
escape()is not present inAbstractViewwhile it is present inHtmlView.I tested this OK and also if I replace the line by
$title = htmlspecialchars($row->title, ENT_QUOTES, 'UTF-8');Note that feedview for a category (blog) is extending
HtmlViewwhere we do have$title = $this->escape($item->$titleField);No idea if the correct solution is to mimick
CategoryFeedViewfor featured view or not.