NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
24 Feb 2019

Summary of Changes

I think as long as we're in full development mode, we should stay up to date to the current version of bootstrap.

Testing Instructions

Run "npm i" and test bootstrap scripts and layouts used in Joomla!

avatar bembelimen bembelimen - open - 24 Feb 2019
avatar bembelimen bembelimen - change - 24 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2019
Category NPM Change
avatar bembelimen bembelimen - change - 24 Feb 2019
The description was changed
avatar bembelimen bembelimen - edited - 24 Feb 2019
avatar bembelimen bembelimen - change - 24 Feb 2019
Title
Update bootstrap version
[4.0] Update bootstrap version
avatar bembelimen bembelimen - edited - 24 Feb 2019
avatar infograf768 infograf768 - change - 25 Feb 2019
Labels Added: NPM Resource Changed ?
avatar wilsonge
wilsonge - comment - 25 Feb 2019

System Tests are repeatedly failing here so I assume this is breaking things

avatar bembelimen
bembelimen - comment - 25 Feb 2019

Not sure, why this happens....
It tries to click on the coordinates (1213, 139) to go to the server area in the global config. Measuring this coordinate in a 1920x1080 screenshot delivers:
grafik

(the bottom right corner is the coordinate), looks good to me + the server tab becomes active when testing this point in the backend..... any ideas?

avatar bembelimen
bembelimen - comment - 25 Feb 2019

Thanks @dneukirchen for fixing the error

avatar wilsonge
wilsonge - comment - 27 Feb 2019

Can you please update the package-lock file too for this change - it should match the package.json - right now you're not actually updating the bootstrap version - just increasing the range of versions available

avatar wilsonge wilsonge - close - 28 Feb 2019
avatar wilsonge wilsonge - merge - 28 Feb 2019
avatar wilsonge wilsonge - change - 28 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-28 13:52:44
Closed_By wilsonge
avatar wilsonge
wilsonge - comment - 28 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment