Feeling Lucky
?
?
[#23997] - [4.0] type_added
- Closed
- 27 Feb 2019
- Medium
- Build: 4.0-dev
- # 23997
- Diff
- puneeth2001:type_added
User tests: Successful: Unsuccessful:
Pull Request for Issue #23948
Summary of Changes
Button tags added
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
?
|
||
bembelimen
- comment
- 24 Feb 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23997.
Quy
- comment
- 24 Feb 2019
Should package-lock.json be included?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23997.
rdeutz
- comment
- 24 Feb 2019
Should package-lock.json be included?
only when package.json is changed
@puneet0191 can you have a look, please?
wilsonge
- comment
- 24 Feb 2019
It shouldn't be changed - seems to be related to npm/npm#20934
Basically @puneeth2001 can you revert the changes in the package-lock please
puneeth2001
- comment
- 25 Feb 2019
ok I'll do it
| Category | Administration com_media NPM Change | ⇒ | Administration com_media |
| Labels |
Removed:
NPM Resource Changed
|
||
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 25 Feb 2019
RT
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23997.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-27 05:44:11 |
| Closed_By | ⇒ | puneeth2001 |
I have tested this item✅ successfully on b1297a9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23997.