? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Feb 2019

It it looks like a button and acts like a button then it should be a

This PR makes sure that the two buttons to select and clear an association are real buttons

image

Any styling issues are beyond the scope of this PR

avatar brianteeman brianteeman - open - 22 Feb 2019
avatar brianteeman brianteeman - change - 22 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2019
Category Administration com_associations
3a7f689 22 Feb 2019 avatar brianteeman oops
avatar brianteeman brianteeman - change - 22 Feb 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 22 Feb 2019

No layout change. It just looks bad

avatar infograf768
infograf768 - comment - 23 Feb 2019
avatar infograf768
infograf768 - comment - 23 Feb 2019

Note: some changes from 3.9 are not yet forwarded to 4.0
#21180

and there are other errors in the functionality (Reference not loaded)

TypeError: element is null[Learn More] joomla-tab.js:387:14

    findAncestor http://localhost:8888/installmulti/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js?dc532af402a4dfa44e535fe6c66405b6:387 connectedCallback http://localhost:8888/installmulti/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js?dc532af402a4dfa44e535fe6c66405b6:79 <anonymous> http://localhost:8888/installmulti/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js?dc532af402a4dfa44e535fe6c66405b6:2 <anonymous> http://localhost:8888/installmulti/joomla40/media/vendor/joomla-custom-elements/js/joomla-tab.js?dc532af402a4dfa44e535fe6c66405b6:1 

YES, I KNOW it is not related to this PR. Just useful to remember.

avatar brianteeman brianteeman - change - 23 Feb 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-02-23 10:23:08
Closed_By brianteeman
avatar brianteeman brianteeman - close - 23 Feb 2019
avatar infograf768
infograf768 - comment - 23 Feb 2019

Why close it? It makes sense afterdeleting . '</a>';
What remains has to be done in other PRs.

Add a Comment

Login with GitHub to post a comment